bugGNU Octave - Bugs: bug #59047, Search dialog moves downward each...

 
 

bug #59047: Search dialog moves downward each time it is opened

Submitter:  Stephan Gebauer <stephan_ii>
Submitted:  Tue 01 Sep 2020 08:47:40 AM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 6.0.90 Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 15 Sep 2020 05:41:26 AM UTC, comment #10: 

@Rik: The on-screen test is done for each dock widget, but AFAIK not for the main window. I will have a look at this.

Torsten Lilge <ttl>
Group Member
Tue 15 Sep 2020 05:39:15 AM UTC, comment #9: 

I have grafted the changeset into stable and have fixed the remaining issue under linux. I am closing the dialog, since splitting the user prefs into roaming and local ones is beyond this bug report.

Torsten Lilge <ttl>
Group Member
Mon 14 Sep 2020 09:36:18 PM UTC, comment #8: 

Is it possible that the fix for a window being offscreen could also be useful in resolving bug #57707?

Rik <rik5>
Group administrator
Sun 13 Sep 2020 11:35:42 AM UTC, comment #7: 

Thanks. I did some tests on Windows 10 and Ubuntu Linux.

What I've noticed on Ubuntu Linux: If I move the search dialog and close it, the next time I open it, it appears some pixels up. But if I don't move the search dialog and close it, it opens at the same position.

On Windows 10, the search dialog re-opens at the expected position no matter what.

If the somewhat inconsistent behavior on Ubuntu Linux is hard to fix, I'd still say this is an important improvement (especially the part that moves the search dialog back on screen) that should go on stable, too.

Markus Mützel <mmuetzel>
Group administrator
Fri 11 Sep 2020 07:17:21 PM UTC, comment #6: 

I have pushed cset http://hg.savannah.gnu.org/hgweb/octave/rev/1ffe315b1052 to default, which fixes the issue with the moving dialog for me. It also checks whether the dialog is outside the available screens. Should the cset be grafted into stable?

Torsten Lilge <ttl>
Group Member
Wed 02 Sep 2020 05:57:42 PM UTC, comment #5: 

The guess with a title bar that is differently included in frame geometries was my first thought, too. The code already takes care of this but obviously in a wrong way. I will have a look at this.

Torsten Lilge <ttl>
Group Member
Wed 02 Sep 2020 07:56:40 AM UTC, comment #4: 

Maybe at that point, we should also check if the search dialog would be rendered off-screen and move it on-screen.
This might especially become an issue in enterprise environments where "octave-gui.ini" in the roaming %APPDATA% folder might be accessed from computers with differing screen resolution.
Would it make sense to store that GUI settings file locally (in %LOCALAPPDATA%) instead?

Markus Mützel <mmuetzel>
Group administrator
Wed 02 Sep 2020 07:09:23 AM UTC, comment #3: 

Thanks for the feedback. I'm glad that solved your problem.

I think the search dialog should open at the same position where it was closed before.
Re-titling the report accordingly.

It might be that the dialog title bar height is not or incorrectly taken into account when positioning the dialog on screen.
CC'ing Torsten because I hope he knows better what the cause might be.

Markus Mützel <mmuetzel>
Group administrator
Wed 02 Sep 2020 07:02:37 AM UTC, comment #2: 

Hi Markus,

you are right, the dialogue was outside the visible area of my screen.

After removing the line in the octave-gui.ini, i can see now

the find&search dialouge. Solved!

THenks for your help!

Stephan Gebauer <stephan_ii>
Tue 01 Sep 2020 02:19:53 PM UTC, comment #1: 

Works for me.
Are you sure you set the focus to the Editor when you hit Ctrl+F?

I noticed that the "Find and Replace" dialog moves down about 100 px each time I open it. It might have moved off the screen for you.
In that case, it might help to open "%APPDATA%/octave/octave-gui.ini", find the line that starts with "fdgl_pos=" and delete that line. Make sure that the Octave GUI doesn't run while you make those modifications.

Markus Mützel <mmuetzel>
Group administrator
Tue 01 Sep 2020 08:47:40 AM UTC, original submission:  

Hi,

On Windows 10 with Octave 6.0.90 in the GUI Editor


open any .m file and press CTRL+F, nothing happens!


in Octave 5.2  you press CTRL+F then the "search and replace" diaglog pops up.

in the settings at the shortcuts, i didn't see any difference in Octave 5.2 and 6.0.90.


Best Regards

Stephan Gebauer <stephan_ii>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by stephan_ii (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-09-15 ttl StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-09-11 ttl StatusConfirmed Ready For Test
    2020-09-02 mmuetzel StatusNone Confirmed
        SummaryCrtl+F doesn't work anymore Search dialog moves downward each time it is opened
        Carbon-Copy- Added ttl

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code