bugGNU nano - Bugs: bug #58972, current answer at Search prompt is...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58972: current answer at Search prompt is lost when something is toggled

Submitter:  Benno Schulenberg <bens>
Submitted:  Mon 17 Aug 2020 05:41:25 PM UTC
   
 
Severity:  4 - Important Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Tue 18 Aug 2020 07:21:13 AM UTC, comment #3: 

Fixed in git, commit b38265cf, by setting 'retain_answer' to TRUE before any of the toggles is handled.

Benno Schulenberg <bens>
Group administrator
Mon 17 Aug 2020 06:04:26 PM UTC, comment #2: 

The difference is that in search_init() the call to do_prompt() happens in a loop, meaning that when 'retain_answer' was FALSE for the first call, it will remain FALSE when something is toggled and the loop gets rerun.  In do_gotolinecolumn() there is no loop and any the ^T toggle results in a new call of search_init() with a TRUE value for 'retain_answer'.  What must have happened during testing is that I first tested ^T before testing the other toggles.  :|

Benno Schulenberg <bens>
Group administrator
Mon 17 Aug 2020 05:51:33 PM UTC, comment #1: 

Bug exists since version 5.0.  The offending commit is bccb0ea0: "handle two similar things in the same way".

Benno Schulenberg <bens>
Group administrator
Mon 17 Aug 2020 05:41:25 PM UTC, original submission:  

To reproduce, run 'src/nano --ignore README',
then type: ^W something M-R
Result: after typing M-R, the "something" string has disappeared.

This is strange.  When I tested the change that is the possible cause of this it worked fine!  Did I again mistest this, running somehow the wrong binary?

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-08-25 bens Open/ClosedOpen Closed
    2020-08-18 bens StatusIn Progress Fixed
        Summarythe current answer at a prompt is lost when something is toggled current answer at Search prompt is lost when something is toggled
    2020-08-17 bens StatusNone In Progress

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code