bugGNUstep - Bugs: bug #58546, GSTLS certificate expiration test...

Group
 
 

bug #58546: GSTLS certificate expiration test always fails on 32-bit architectures

Submitter:  Yavor Doganov <yavor>
Submitted:  Thu 11 Jun 2020 05:07:00 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  CaS
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 12 Jun 2020 08:41:13 AM UTC, comment #5: 

In practice, I don't see testing this on 32bit systems as a priority.  If the tests pass on 64bit systems then the code is very unlikely to have been broken (and now that the world has moved to 64bit, it doesn't seem important to have a specific test for 32bit systems).

Richard Frith-Macdonald <CaS>
Group Member
Fri 12 Jun 2020 08:36:40 AM UTC, comment #4: 

AFAIK, the time_t limitation is on all 32 bit systems, at least glibc-based ones.  IIRC, there were some discussions to address this issue but it turned out that such a change would break the ABI.

Perhaps you mean *BSD systems or some Unix flavours?

Yavor Doganov <yavor>
Fri 12 Jun 2020 08:36:30 AM UTC, comment #3: 

Sorry for the confusion. Richard and I worked on this item at the same time so I did not see he already accepted this patch.

Fred Kiefer <FredKiefer>
Group Member
Fri 12 Jun 2020 08:29:46 AM UTC, comment #2: 

As far as I understand this you mean that this test is bound to fail on some 32bit systems as the expiration date of the certificate in 2118 can not be represented on that systems. This is due to time_t being 32 bits on some systems. As this is not true on all 32 bit system I would prefer to just mark this test as hopeful. This should have similar results as your change.

Fred Kiefer <FredKiefer>
Group Member
Fri 12 Jun 2020 08:15:57 AM UTC, comment #1: 

Thanks for spotting that ... patch applied.

Richard Frith-Macdonald <CaS>
Group Member
Thu 11 Jun 2020 05:07:00 PM UTC, original submission:  

See the attached patch.  Another solution is to replace the test certificate with a one that expires before 2038.

Yavor Doganov <yavor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by yavor (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-12 FredKiefer StatusConfirmed Fixed
        Assigned toNone CaS
        Open/ClosedOpen Closed
    2020-06-12 FredKiefer StatusNone Confirmed
        Open/ClosedClosed Open
    2020-06-12 CaS Open/ClosedOpen Closed
    2020-06-11 yavor Attached File- Added gstls-time_t-limitation.patch, #49243

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code