bugGNU Octave - Bugs: bug #58330, Do not warn in ./configure for...

 
 

bug #58330: Do not warn in ./configure for explicit --without-XXX arguments

Submitter:  Andrew Janke <apjanke>
Submitted:  Thu 07 May 2020 08:54:07 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 18 May 2020 03:09:10 PM UTC, comment #10: 

I opened bug #58394 for the switches missing for the "no-extras" builder.

Markus Mützel <mmuetzel>
Group administrator
Mon 18 May 2020 02:44:27 PM UTC, comment #9: 

Markus: You can open bug reports for the buildbot config on the Octave bug tracker.

John W. Eaton <jwe>
Group administrator
Mon 18 May 2020 02:10:04 PM UTC, comment #8: 

I'm not sure where bugs with the buildbot configuration should be reported. On the mailing list? Or here on savannah?

Otherwise, this seems to work now. Thanks for the quick fix.

Markus Mützel <mmuetzel>
Group administrator
Sun 17 May 2020 09:10:15 PM UTC, comment #7: 

Slightly different issue.  The buildbot --no-extras doesn't seem to disable every library that it could.  I used grep for '--without' on the help text from ./configure and I came up with this list:


  --without-libiconv-prefix     don't search for libiconv in includedir and libdir
  --without-qhull         don't use QHull library
  --without-z             don't use ZLIB library
  --without-bz2           don't use BZIP2 library
  --without-hdf5          don't use HDF5 library
  --without-fftw3         don't use FFTW3 library
  --without-fftw3f        don't use FFTW3F library
  --without-glpk          don't use GLPK library
  --without-curl          don't use cURL library
  --without-sndfile       don't use sndfile library, disable audio file I/O
  --without-portaudio     don't use PortAudio library, disable audio playback
  --without-framework-carbon
  --without-opengl        don't use OpenGL libraries, disable OpenGL graphics
  --without-framework-opengl
  --without-freetype      don't use FreeType library, OpenGL graphics will not
  --without-fontconfig    don't use fontconfig library, OpenGL graphics will
  --without-qt            don't use Qt libraries, disable Qt GUI
  --without-qscintilla    disable QScintilla editor
  --without-fltk          don't use FLTK libraries, disable OpenGL graphics
  --without-qrupdate      don't use qrupdate, disable QR & Cholesky updating
  --without-suitesparseconfig
  --without-amd           don't use AMD library, disable some sparse matrix
  --without-camd          don't use CAMD library, disable some sparse matrix
  --without-colamd        don't use COLAMD library, disable some sparse matrix
  --without-ccolamd       don't use CCOLAMD library, disable some sparse
  --without-cholmod       don't use CHOLMOD library, disable some sparse
  --without-cxsparse      don't use CXSparse library, disable some sparse
  --without-umfpack       don't use UMFPACK, disable some sparse matrix
  --without-klu           don't use KLU library, disable some sparse matrix
  --without-sundials_nvecserial
  --without-sundials_ida  don't use SUNDIALS IDA library, disable solvers
  --without-sundials_sunlinsolklu
  --without-arpack        don't use the ARPACK library, disable eigs function


The arguments that don't seem to be in the buildbot are --without-fontconfig and --without-freetype.



Rik <rik5>
Group administrator
Sun 17 May 2020 09:02:40 PM UTC, comment #6: 

Okay, I checked in changeset 28304:144d77f3f829 which seems to fix the problem for me.

Rik <rik5>
Group administrator
Sun 17 May 2020 08:39:39 PM UTC, comment #5: 

I found a few more instances where configure.ac was checking for warnings rather than for installed libraries.  I'm compiling now to see if all of my changes made sense.

Rik <rik5>
Group administrator
Sun 17 May 2020 08:18:18 PM UTC, comment #4: 

Yes, that second bit of configure.ac is wrong.  Instead of checking for a warning, the check should be on wheth HAVE_ZLIB is defined or something similar.  Let me take a quick look.

Rik <rik5>
Group administrator
Sun 17 May 2020 08:12:18 PM UTC, comment #3: 

Maybe related to this section in configure.ac:

### Check for ZLIB library.

OCTAVE_CHECK_LIB(z, ZLIB,
  [ZLIB library not found.  Octave will not be able to load or save compressed data files or HDF5 files.],
  [zlib.h], [gzclearerr])

## Also define HAVE_ZLIB if libz is found.
if test -z "$warn_z"; then
  AC_DEFINE(HAVE_ZLIB, 1, [Define to 1 if ZLIB is available.])
fi


Markus Mützel <mmuetzel>
Group administrator
Sun 17 May 2020 08:05:31 PM UTC, comment #2: 

The no-extras buildbot fails on the compile step since this change:
http://buildbot.octave.org:8010/#/builders/7/builds/1587/steps/5/logs/stdio

I tried with these configure settings (the same as what the buildbot uses plus the --prefix):

../configure --prefix=${HOME}/usr --disable-docs --disable-fftw-threads --disable-java --disable-jit --disable-openmp --disable-readline --without-osmesa --without-amd --without-arpack --without-bz2 --without-camd --without-ccolamd --without-cholmod --without-colamd --without-curl --without-cxsparse --without-fftw3 --without-fftw3f --without-fltk --without-framework-opengl --without-glpk --without-hdf5 --without-klu --without-sundials-ida --without-sundials_nvecserial --without-magick --without-opengl --without-openssl --without-portaudio --without-qhull --without-qrupdate --without-qscintilla --without-qt --without-sndfile --without-sundials_ida --without-sundials_nvecserial --without-umfpack --without-x --without-z


Even if "--without-z" is used, HAVE_ZLIB is defined in config.h:

/* Define to 1 if ZLIB is available. */
/* #undef HAVE_Z */

/* Define to 1 if ZLIB is available. */
#define HAVE_ZLIB 1

/* Define to 1 if you have the <zlib.h> header file. */
/* #undef HAVE_ZLIB_H */


I'm not sure why there is HAVE_Z and HAVE_ZLIB (and why one is defined and the other is not).

Markus Mützel <mmuetzel>
Group administrator
Sat 16 May 2020 06:10:52 PM UTC, comment #1: 

I think I fixed everything up in this changeset: https://hg.savannah.gnu.org/hgweb/octave/rev/a8f6a7083428.

Marking as Ready for Test.

Rik <rik5>
Group administrator
Thu 07 May 2020 08:54:07 PM UTC, original submission:  

Following up on https://savannah.gnu.org/bugs/?58321.

The current build system, in at least some cases, emits warnings like "WARNING: blah is disabled" when the caller supplies --without-XXX arguments, such as --without-fltk. (Though FLTK in specific is fixed now.)

If the user is explicitly asking for --without-XXX, we should assume they know what they're doing, and not warn about the absence of XXX, since that was the requested behavior. Let's modify the `configure` script to only emit warnings for unavailable/non-selected components if they were selected by default and then found to be absent by detection, and never warn about components that were explicitly disabled using --without-XXX options to configure.

Andrew Janke <apjanke>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by apjanke (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-22 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-05-16 rik5 StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code