bugGNU roff - Bugs: bug #58164, smoke-test_html_device.sh fails...

 
 

bug #58164: smoke-test_html_device.sh fails when a non-utf-8 charmap is used

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sun 12 Apr 2020 07:47:45 PM UTC
   
 
Category:  Core Severity:  3 - Normal
Item Group:  Test Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 01 Apr 2023 03:07:04 PM UTC, comment #5: 


commit d00b53e122fc56819a2d87feab3d79ee916705d5
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Apr 13 07:55:13 2020 +1000

    Fix locale problem in regression test.

    * src/roff/groff/tests/smoke-test_html_device.sh: Set LC_CTYPE=C.UTF-8
      so that byte sequences in the pipelines are handled correctly.  Thanks
      to Bjarni Ingi Gislason for the trouble report.

    Fixes <https://savannah.gnu.org/bugs/?58164>.

commit be938bab8be71b54f107a56a1025d5c916b107dc
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Mon Apr 13 23:09:16 2020 +1000

    Skip HTML output test if UTF-8 not available.

    * src/roff/groff/tests/smoke-test_html_device.sh: Skip the test if the
      environment doesn't support UTF-8 (according to 'locale -k charmap').


G. Branden Robinson <gbranden>
Group administrator
Sun 19 Apr 2020 10:12:39 AM UTC, comment #4: 

original submission:

> N.B.
>   Give each test a ordinal number in the output (and the total).


I failed to address this suggestion.

This is not practical; the tests do not run in a deterministic order, and moreover there is no inherent total ordering among them.

G. Branden Robinson <gbranden>
Group administrator
Mon 13 Apr 2020 01:13:46 PM UTC, comment #3: 

I noticed this myself when running the test suite under an is_IS.ISO-8859-1 environment.

Try the commit I just pushed, be938bab8be71b54f107a56a1025d5c916b107dc.

G. Branden Robinson <gbranden>
Group administrator
Mon 13 Apr 2020 01:00:11 PM UTC, comment #2: 

  I still have an error.

  A robust way to treat input in UTF-8 is to explicitly set the
encoding for "preconv" with "-K UTF-8".

  So exchange '-k' with '-K UTF-8' for the first test (in two places)

  The line

LC_CTYPE=C.UTF-8

  can then be removed.

Bjarni Ingi Gislason <bjarniig>
Sun 12 Apr 2020 09:59:13 PM UTC, comment #1: 

Fixed in d00b53e122fc56819a2d87feab3d79ee916705d5.

G. Branden Robinson <gbranden>
Group administrator
Sun 12 Apr 2020 07:47:45 PM UTC, original submission:  

Subject: First html-test fails when a non-utf-8 charmap is used

  The first test in "src/roff/groff/tests/smoke-test_html_device.sh"
fails in locales with one octet per character,
for example ISO-8859-1 (latin1).

N.B.
  Give each test a ordinal number in the output (and the total).

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-04-01 gbranden Planned Release1.22.4 1.23.0
    2023-04-01 gbranden Planned ReleaseNone 1.22.4
        SummaryFirst html-test fails when a non-utf-8 charmap is used smoke-test_html_device.sh fails when a non-utf-8 charmap is used
    2020-04-12 gbranden StatusNone Fixed
        Assigned toNone gbranden
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code