bugGNU Octave - Bugs: bug #58057, preface.texi should depend on...

 
 

bug #58057: preface.texi should depend on contributors.texi

Submitter:  Michael Orlitzky <mjo>
Submitted:  Fri 27 Mar 2020 02:40:07 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 5.2.0 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 27 Mar 2020 08:14:31 PM UTC, comment #5: 

I applied this to the stable branch. Thanks again!

Mike Miller <mtmiller>
Group Member
Fri 27 Mar 2020 05:21:56 PM UTC, comment #4: 

Thanks, that was fast!

I'm planning on applying this to the stable branch and doing some simple tests to make sure it rebuilds when it's supposed to. Since the patch is so simple and we have a good guess at the origin, I'll commit under my name but acknowledge both Sébastien and Michael in the commit message.

Mike Miller <mtmiller>
Group Member
Fri 27 Mar 2020 04:49:37 PM UTC, comment #3: 

You have to go pretty far back, but I think this is the origin of the patch:

31 Jan 2012; Sébastien Fabbro <bicatali@gentoo.org> octave-3.4.3-r1.ebuild,
  +files/octave-3.4.3-texi.patch, octave-3.6.0.ebuild:
  Remove openmp (too experimental, do it with EXTRA_ECONF if interested), fixed
  a parallel build issue (bug #401189), remove obsolete configure option

Michael Orlitzky <mjo>
Fri 27 Mar 2020 04:48:53 PM UTC, comment #2: 

Mike: I agree that we should credit whoever wrote this change for gentoo if they want credit.  But as a fairly trivial one line change, it would also be OK to just check it in under your name with a note about the origin of the change.

John W. Eaton <jwe>
Group administrator
Fri 27 Mar 2020 04:29:59 PM UTC, comment #1: 

Thanks, this looks like a valid rule that we should include.

Do you have any author attribution for this patch? A name and email address for who originally wrote the patch for Gentoo? Or a packaging repository I can look at?

Mike Miller <mtmiller>
Group Member
Fri 27 Mar 2020 02:40:07 PM UTC, original submission:  

We carry a patch in Gentoo to address a build failure related to the documentation:


--- a/doc/interpreter/module.mk        2018-04-30 19:03:56.000000000 +0200
+++ a/doc/interpreter/module.mk.new        2018-05-22 12:17:03.587175816 +0200
@@ -368,6 +368,8 @@
         $(AWK) -f $(srcdir)/%reldir%/mkcontrib.awk $(srcdir)/%reldir%/contributors.in > $@-t && \
         mv $@-t $@

+%reldir%/preface.texi: %reldir%/contributors.texi
+
 AUTHORS: %reldir%/preface.texi %reldir%/contributors.texi | %reldir%/$(octave_dirstamp)
         $(AM_V_MAKEINFO)rm -f $@-t $@ && \
         if [ "x$(srcdir)" != "x." ] && [ -f $(srcdir)/%reldir%/contributors.texi ] && [ ! -f %reldir%/contributors.texi ]; then \


During a parallel build, we need to ensure that contributors.texi is created before preface.texi tries to include it.

I know we shouldn't be building the documentation, but because we carry so many other patches to the build system, we wind up running autoreconf, and... it happens. Regardless, the patch should be correct even if you don't expect end users to be building the docs.

Michael Orlitzky <mjo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mjo (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-03-27 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2020-03-27 mtmiller CategoryDocumentation Configuration and Build System
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code