bugGNU source-highlight - Bugs: bug #57910, Function color defaults to black

 
 

bug #57910: Function color defaults to black

Submitter:  None
Submitted:  Thu 27 Feb 2020 06:53:24 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 11 Jun 2020 02:28:19 AM UTC, comment #1: 

I pushed a fix for this a while ago.

commit b4fc95d90a702d2001369d68d0972a43caa172be
Author: Tom Tromey <tom@tromey.com>
Date:   Sat Jun 1 13:42:36 2019 -0600

    Don't use "black" in esc.style
   
    Bug #55967 points out that using "black" in the function style in
    esc.style makes function names unreadable on a dark-theme
    terminal. The suggested fix, removing "black", seemed reasonable to
    me, so I am checking it in.

Tom Tromey <tromey>
Group administrator
Thu 27 Feb 2020 06:53:24 PM UTC, original submission:  

It seems that, by default, the highlight color for function names defaults to black: In default.style , it says:

function black b; // for function calls and declarations


Now, for most terminal colors I suppose this is fine; but - black is the most popular, or second most popular, terminal background color, and on black terminals we can't see black text...

So, this is a poor default. There might not be a perfect choice of a highlight color, but black isn't it.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tromey (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-11 tromey StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code