bugGNU GRUB - Bugs: bug #57889, grub-install no longer installs...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #57889: grub-install no longer installs locales

Submitter:  Martin Whitaker <martinwhitaker>
Submitted:  Mon 24 Feb 2020 11:00:17 PM UTC
Votes: 100
 
Category:  Installation Severity:  Major
Priority:  5 - Normal Item Group:  Software Error
Status:  None Privacy:  Public
Assigned to:  None Originator Name: 
Open/Closed:  Open Release:  Git master
Release:  Reproducibility:  Every Time
Planned Release:  None

Mon 04 Jan 2021 01:08:59 PM UTC, comment #1: 

Wow, spent some time tracking this bug down the rabbit hole as I am trying to teach i18n to our https://schulstick.org/ .. I see the fix has been applied since 3½ months, but no release has been cut.

Please consider tagging releases more often (and be it 2.05.x "unstable" releases) so fixes trickle down the distributions' packaging workflows and less time is wasted on user's end.... uhm and thanks for all teh bootloaderz! : )

Marcel Partap <empee584>
Mon 24 Feb 2020 11:00:17 PM UTC, original submission:  

grub-install should install the specified (or, if not specified, all available) locale files in the target directory. As of 2.04, it no longer does this. This regression was introduced by

> commit 3d8439da8c9a4acf9bc1c41b364ec6e1680ef052
> Author: Olaf Hering <olaf@aepfle.de>
> Date:   Fri Apr 13 23:36:49 2018 +0200
>
>     grub-install: Locale depends on nls
>    
>     With --disable-nls no locales exist.


This commit surrounds the code that copies the locale files with the condition

> #if !(defined (GRUB_UTIL) && defined(ENABLE_NLS) && ENABLE_NLS)


This condition is inverted, and should be

> #if (defined (GRUB_UTIL) && defined(ENABLE_NLS) && ENABLE_NLS)


The attached patch fixes the problem.

Martin Whitaker <martinwhitaker>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by empee584 (Posted a comment)
  • -email is unavailable- added by empee584 (Voted in favor of this item)
  • -email is unavailable- added by martinwhitaker (Submitted the item)
  •  

    There are 100 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-03-28 ineiev Attached File#54534 Removed
    2023-03-28 ineiev Carbon-CopyRemoved 341921 -
    2023-03-27 _341921 Attached File- Added ssavannah.gnu.txt, #54534
    2021-01-04 empee584 Carbon-Copy- Added empee584
    2020-02-24 martinwhitaker Attached File- Added 0001-grub-install-fix-inverted-test-for-NLS-enabled-when-.patch, #48494

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code