bugGNU Octave - Bugs: bug #57130, Missing "uisetfont"...

 
 

bug #57130: Missing "uisetfont" function

Submitter:  Pantxo Diribarne <pantxo>
Submitted:  Mon 28 Oct 2019 10:57:02 AM UTC
   
 
Category:  Octave Function Severity:  1 - Wish
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  pantxo
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 04 Nov 2019 03:32:16 PM UTC, comment #5: 

Thanks Rik for the thorough review. I remove uisetfont from the list of unimplemented functions, and remove a leftover kyboard statement here:

http://hg.savannah.gnu.org/hgweb/octave/rev/ef31cf01917f

Pantxo Diribarne <pantxo>
Group Member
Sun 03 Nov 2019 10:32:22 PM UTC, comment #4: 

Thanks Pantxo.  I reviewed the second patch and checked it in here (https://hg.savannah.gnu.org/hgweb/octave/rev/698c8b08fe8c).

I made a few changes to make it more Matlab-compatible such as making the window Modal, and reversing the left-to-right ordering of the "Ok" and "Cancel" buttons.  The list of diffs is attached if you're interested.

Marking as fixed and closing report.


(file #47794)

Rik <rik5>
Group administrator
Tue 29 Oct 2019 11:28:30 PM UTC, comment #3: 

I attached an updated patch. I changed significantly the input checking and output retrieval so I may have introduced errors.

(file #47766)

Pantxo Diribarne <pantxo>
Group Member
Tue 29 Oct 2019 11:29:47 AM UTC, comment #2: 

@Guillaume: Thanks, I'll fix the two issues you reported so far.

Pantxo Diribarne <pantxo>
Group Member
Mon 28 Oct 2019 11:57:39 AM UTC, comment #1: 

I could apply and compile your patch without problem.

It also seems to run fine. One thing I notice is that the default size in the uicontrol is "8" but the sample text displayed seems to be "10", i.e. if I click on "8", the text gets smaller.

There is a typo in the help text of uisetfont.m: "propoerties"

Guillaume <gyom>
Mon 28 Oct 2019 10:57:02 AM UTC, original submission:  

Once I have a bug number,  I'll attach a patch that implements the "uisetfont" function. This function is very useful for testing the rendering of installed system fonts in Octave's OpenGL graphics system.

Can someone give it a try?

Pantxo Diribarne <pantxo>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47794:  57130.diffs added by rik5 (23KiB - application/octet-stream)
file #47766:  uisetfont_4.patch added by pantxo (23KiB - text/x-patch)
file #47758:  bug#57130_uisetfont.patch added by pantxo (23KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by gyom (Posted a comment)
  • -email is unavailable- added by pantxo (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-11-03 rik5 Attached File- Added 57130.diffs, #47794
        StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2019-10-29 pantxo Attached File- Added uisetfont_4.patch, #47766
    2019-10-28 pantxo SummaryMissing &quot;uisetfont&quot;, function Missing "uisetfont" function
    2019-10-28 pantxo Attached File- Added bug #57130_uisetfont.patch, #47758
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code