bugGNU Octave - Bugs: bug #57009, [octave forge] (image) Spelling...

 
 

bug #57009: [octave forge] (image) Spelling error in doc string of nonmax_supress

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Sun 06 Oct 2019 07:31:30 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 07 Oct 2019 12:14:12 PM UTC, comment #3: 

I have now renamed the old incorrectly named function with
http://hg.code.sf.net/p/octave/image/rev/829eafaddc42

I have added a simple passthough with the spelling error for backwards compatibility. Use of the old name does not raise any warning on purpose.

Carnë Draug <carandraug>
Group Member
Mon 07 Oct 2019 11:40:57 AM UTC, comment #2: 

Thank you for the bug report and patch. I have pushed it with http://hg.code.sf.net/p/octave/image/rev/b471392a0cfa

About fixing the actual function name, the documentation does state that the function is not meant for general use and should only be used by the edge function for canny edge detection. Still, this is not a dunder function (which should be if it's meant to be private), so I don't want to fix that. I'll see about renaming the function with the proper spelling and keeping the incorrect spelling around for backwards compatibility.

Carnë Draug <carandraug>
Group Member
Sun 06 Oct 2019 06:41:54 PM UTC, comment #1: 

adding people to cc

Hartmut <hardy>
Sun 06 Oct 2019 07:31:30 AM UTC, original submission:  

The word “suppression” is misspelled in the documentation string of function nonmax_supress.  The patch attached to this bug report fixes the problem.

The spelling error also occur in the function name, unfortunately.

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by hardy (Posted a comment)
  • -email is unavailable- added by hardy
  • -email is unavailable- added by hardy
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-10-07 carandraug StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2019-10-06 hardy Carbon-Copy- Added avinoam
        Carbon-Copy- Added carandraug
    2019-10-06 siko1056 StatusNone Patch Submitted
    2019-10-06 rlaboiss Attached File- Added spelling-nonmax-supress.patch, #47622

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code