bugGNU arch -- a revision control system - Bugs: bug #5690, Add a precommit hook

 
 

bug #5690: Add a precommit hook

Submitted by:  Erik de Castro Lopo <mega-nerd>
Submitted on:  Thu 02 Oct 2003 10:55:30 AM UTC  
 
Category: tlaSeverity: 3 - Normal
Item Group: small feature ideaStatus: Fixed
Privacy: PublicOpen/Closed: Closed
Release: tla-1.1pre5
Fixed Release: 
Merge Request?: None
Your Archive Name: 
Your Archive Location: 
Assigned to: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 25 Nov 2003 09:36:05 PM UTC, comment #2:

merged into lord@emf.net--2003b/tla--devo--1.1--patch-201

Robert Collins <robertc>
Sat 08 Nov 2003 01:44:06 AM UTC, comment #1:

I've committed this into my archive as rbtcollins@hotmail.com--barch/tla--devo--1.1--patch-22.

Robert Collins <robertc>
Thu 02 Oct 2003 10:55:30 AM UTC, original submission:

There is currently a hook in the commit function which runs
at the end of the commit process. It would also be useful
to have a hook run at the start of the commit process and
be able to abort the commit process by returning a non-zero
error code from the hook script.

An example of what can be done with this is to do a make in
the the hook script and have the script return make's error
code. This means that a compile will be done during the
commit hook and if the code doesn't build it won't commit
and broken code doesn't get into the archive.

Obviously if someone wants to bypass this process they can.
This is meant to prevent accidental commits of broken code.

I have included a diff which seems to work for me, but I'm
not totally sure that its correct. I have also mentioned
the previous version of this patch on the mailing list.

Erik de Castro Lopo <mega-nerd>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #706:  tla-1.1pre5-precommit.diff added by mega-nerd (2KiB - application/octet-stream - A patch that seems to work.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 25 Nov 2003 09:36:05 PM UTCrobertcStatusNone=>(Error - Not Found)
  Open/ClosedOpen=>(Error - Not Found)

Back to the top


Powered by Savane 3.1-cleanup1