bugGNU arch -- a revision control system - Bugs: bug #5598, tla commit --file-list barfs on...

 
 

bug #5598: tla commit --file-list barfs on binary files

Submitter:  Invalid User ID <#22978>
Submitted:  Sat 27 Sep 2003 09:04:42 PM UTC
   
 
Category:  tla Severity:  3 - Normal
Item Group:  bug Status:  None
Privacy:  Public Open/Closed:  Open
Release:  lord@emf.net--2003b/tla--devo--1.1--patch-183
Fixed Release: 
Merge Request?:  None
Your Archive Name: 
Your Archive Location: 
Assigned to:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 27 Sep 2003 09:04:42 PM UTC, original submission:  

Here is a copy of the message that I sent to gnu-arch-users

Hi Tom,

I figured out the problem I had with a botched changeset.  This is a
tla bug.

Suppose you have a project with a binary file foo.gz and suppose you
modify this file.  If you try to commit as follows:

echo foo.gz > ,,FILES
tla commit -L "watch me die" --file-list ,,FILES

then it will output the following error message AND check in the
botched changeset anyway:

arch_apply_changeset: internal error (patch(1) returned odd status)
   patch(1) exit status: 2

patch: ** Only garbage was found in the patch input.

The reason is that the diff file contains the line:

Files orig/foo.gz and mod/foo.gz differ

The reason for this is that make-changeset-files.c does not implement
the correct logic for dealing with the return status of
arch_invoke_diff.  In fact it doesn't deal with it at all.

After looking at the code, I am under the impression that you must
have had some sort of plan to eventually dump
arch_make_files_changeset in favor of a call to arch_make_changeset
with an appropriate limits_spec argument, but that that hasn't
happened yet.  Am I correct, or completely off base?

If I am right, should I attempt to make this change?

Cheers,

Invalid User ID <#22978>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

No changes have been made to this item

Back to the top

Powered by Savane 3.13-12ab.
Corresponding source code