bugGNU nano - Bugs: bug #55773, in current git, when a status-bar...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #55773: in current git, when a status-bar message does not fit, the last column is unused

Submitter:  Benno Schulenberg <bens>
Submitted:  Sun 24 Feb 2019 11:36:19 AM UTC
   
 
Severity:  2 - Minor Status:  Fixed
Assigned to:  dolorous Open/Closed:  Closed

Thu 28 Feb 2019 06:54:12 PM UTC, comment #3: 

Thanks.  I've melded the two patches, as dropping the check for currmenu != MMAIN should go hand-in-hand with the removal of the setting of currmenu to MMAIN.

Applied to master and pushed, commit f13dd140.

Benno Schulenberg <bens>
Group administrator
Wed 27 Feb 2019 08:56:26 PM UTC, comment #2: 

Attached patches against git de47b58 which should fix this.

The first patch reverts commit 14f32577, which is part of the same botched logic; the second patch makes display_string() use a parameter indicating when we're at a prompt (and updates in-code documentation accordingly).

(file #46369, file #46370)

David Lawrence Ramsey <dolorous>
Group Member
Sun 24 Feb 2019 11:46:58 AM UTC, comment #1: 

The 'currmenu != MMAIN' in display_string() is a botch, of course, an improper repair.  I used it to avoid having to add another parameter to the function.  But... it seems we can't escape having to add this parameter.  :|

Benno Schulenberg <bens>
Group administrator
Sun 24 Feb 2019 11:36:19 AM UTC, original submission:  

To reproduce, make your terminal 15 columns wide and then run: src/nano --ignore NEWS.  See how the message "Read 1833 lines" fits exactly on the status bar and is complete.  Now exit from nano and make the terminal one column narrower (14 columns) and then run the same command again.  See how now the status bar shows "Read 1833 lin ", with a blank, unhighlighted last position.  Looks strange and incorrect.

Bug was introduced by commit 56181896, two weeks ago.

This affects only status-bar messages, not constant position display, not word count, not the prompts.

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dolorous (Updated the item)
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-28 bens StatusNone Fixed
        Assigned toNone dolorous
        Open/ClosedOpen Closed
    2019-02-27 dolorous Attached File- Added 0001-display-no-longer-change-menus-before-displsying-spo.patch, #46369
        Attached File- Added 0002-display-indicate-being-at-a-prompt-with-a-display_st.patch, #46370

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code