bugGNU nano - Bugs: bug #55352, after redoing the deletion of a...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #55352: after redoing the deletion of a character, a wrong file size is shown

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Mon 31 Dec 2018 08:50:20 PM UTC  
 
Severity:  2 - Minor Status:  Fixed
Assigned to:  Benno Schulenberg <bens> Open/Closed:  Closed

Tue 01 Jan 2019 11:38:17 AM UTC, comment #2: 

Fixed in git, commit 329b82d2.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 01 Jan 2019 11:25:14 AM UTC, comment #1: 

Bug was introduced in version 2.5.0.  The offending commit is 66e21416, which tried to fix bug #45523.

The bug got worse in version 2.9.8, commit 856322b0 -- which is weird because totally unrelated.

In 3.0 the bug morphed again, switching from showing too small a size to too large a size (after a redo of a character deletion).

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 31 Dec 2018 08:50:20 PM UTC, original submission:  

To reproduce, run 'src/nano --ignore --constant'.
Then type: x
See that it says 1/2 chars: the x plus the magic newline.
Type: <Backspace>
See that it says 0/1 chars: just the magic newline remains.
Now type: M-U M-E ^C
See that it now says 0/2 chars.  This is wrong, because after an undo and redo, it is still just the magicline that remains: 1 character.

Bug was found by code inspection.  It needs the same storing of the newsize as for the other part of do_deletion(), the line-joining part.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-25 bens Open/ClosedOpen => Closed
    2019-01-01 bens Severity3 - Normal => 2 - Minor
        StatusIn Progress => Fixed
    2019-01-01 bens Summaryredoing the deletion of a character misshows the file size => after redoing the deletion of a character, a wrong file size is shown

    Back to the top


    Powered by Savane 3.5