bugGNU Octave - Bugs: bug #55349, Building with --enable-jit fails...

 
 

bug #55349: Building with --enable-jit fails with LLVM 3.8.x

Submitter:  Julien Bect <jbect>
Submitted:  Mon 31 Dec 2018 06:48:11 PM UTC
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 5.0.0 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

( Jump to the original submission )

Thu 03 Jan 2019 09:21:45 AM UTC, comment #8: 

Patches that make it possible to build with LLVM 3.9 and 4.0 are now available on the patch tracker: https://savannah.gnu.org/patch/?9741.

Note also that another ticket about building with LLVM 3.8 already existed: https://savannah.gnu.org/bugs/?51574.  Sorry for the duplicate.

Julien Bect <jbect>
Wed 02 Jan 2019 01:09:40 AM UTC, comment #7: 

Rik,

OK to put this in default? Current Fedora 29 has 3.9

Michael Godfrey <godfrey>
Project Member
Tue 01 Jan 2019 06:18:08 PM UTC, comment #6: 

Too late for this release, but put them on the patch tracker.

Rik <rik5>
Project Administrator
Tue 01 Jan 2019 04:19:04 PM UTC, comment #5: 

Thank you.

To answer partially the question in your comment #3: the only version of LLVM that is currently supported in 3.8.x.

I have a small set of patches that allows to compile for both 3.8.x and 3.9.x, would this be interesting for the upcoming release?  Where should I put them? (another bug report? a ticket on the patch tracker? elsewhere?)

Julien Bect <jbect>
Tue 01 Jan 2019 04:14:46 PM UTC, comment #4: 

Woops, I see that it was internal re-factoring in Octave, rather than changes to LLVM that caused the problem.  I pushed your changeset here: https://hg.savannah.gnu.org/hgweb/octave/rev/b880c6426424.

Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Tue 01 Jan 2019 04:11:23 PM UTC, comment #3: 

Will this be okay with previous versions of LLVM as well, or does this require adding tests in configure to determine the LLVM version and then #ifdef around this specific change?

Rik <rik5>
Project Administrator
Tue 01 Jan 2019 09:58:51 AM UTC, comment #2: 

Sorry about that, I probably forgot to attach it ;-)

Here it is.

(file #45821)

Julien Bect <jbect>
Mon 31 Dec 2018 11:15:55 PM UTC, comment #1: 

Your patch apparently wasn't uploaded.  Could you try again?

Rik <rik5>
Project Administrator
Mon 31 Dec 2018 06:48:11 PM UTC, original submission:  

Octave no longer builds with --enable-jit.  It worked with Octave 4.4.1.

The reason is a recent changeset (2eb71b83d3e2: partially refactor function lookup in symbol table) which removed the ::find method from the symbol_table class.

The attached patch fixes the problem by calling ::builtin_find instead.  Tested with LLVM 3.8.1 on stable.

Julien Bect <jbect>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45821:  jit-symtab-find.patch added by jbect (886B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by godfrey (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jbect (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-01 rik5 StatusNeed Info Fixed
        Open/ClosedOpen Closed
    2019-01-01 jbect Attached File- Added jit-symtab-find.patch, #45821
    2018-12-31 rik5 StatusNone Need Info

    Back to the top


    Powered by Savane 3.9