GNU nano - Bugs: bug #54948, when using -K,...
You are not allowed to post comments on this tracker with your current authentication level.
bug #54948: when using -K, <Shift+Delete> says "Unknown sequence"
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Sun 04 Nov 2018 10:52:43 AM UTC | ||
Severity: | 2 - Minor | Status: | Fixed |
Assigned to: | dolorous | Open/Closed: | Closed |
Jump to the original submission
Wed 07 Nov 2018 08:26:40 PM UTC, comment #12: |
David Lawrence Ramsey <dolorous> |
Wed 07 Nov 2018 07:40:52 PM UTC, comment #11: (The modified <Delete> key entering spurious stuff into the buffer in the tiny version is a separate bug. Please report. A patch should include in the tiny version the least amount of code to avoid the spurious stuff.) |
Benno Schulenberg <bens> |
Wed 07 Nov 2018 06:58:48 PM UTC, comment #10: Thanks. I'm not that familiar with the Linux console bits. |
David Lawrence Ramsey <dolorous> |
Wed 07 Nov 2018 06:20:04 PM UTC, comment #9: Fixed in git, commit f55a3fab. Thanks for the patch.
|
Benno Schulenberg <bens> |
Wed 07 Nov 2018 03:18:49 PM UTC, comment #8: (Crossreference: the Backspace key not working in help viewer and file browser has been reported as bug #54978.) |
Benno Schulenberg <bens> |
Wed 07 Nov 2018 12:40:46 AM UTC, comment #7: And reported the other bug separately, with more details. Depending on the terminal you're using, it either works in the help viewer but not in the file browser, or doesn't work in either the help viewer or file browser. |
David Lawrence Ramsey <dolorous> |
Wed 07 Nov 2018 12:21:47 AM UTC, comment #6: Attached new version, resynced against git 7ee07af. The code asking ncurses for the key is gone, as is the modifier handling.
|
David Lawrence Ramsey <dolorous> |
Tue 06 Nov 2018 08:13:56 PM UTC, comment #5: (On FreeBSD, even without -K <Shift+Delete> says unknown sequence. The sequence of hex codes it sees is: 1b 5b 33 3b 32 7e.) |
Benno Schulenberg <bens> |
Tue 06 Nov 2018 07:54:55 PM UTC, comment #4: Oh, and yes, please report the other bug separately. I already know how to fix it. (For me, <Backspace> still works in the help viewer, but it has been broken in the file browser since version 2.9.2.) |
Benno Schulenberg <bens> |
Tue 06 Nov 2018 06:41:53 PM UTC, comment #3: Hmmm... It should not be necessary to ask ncurses for the keycode for the shifted Delete key, because it has a code by default: KEY_SDC.
|
Benno Schulenberg <bens> |
Tue 06 Nov 2018 02:51:12 AM UTC, comment #2: (And, for the record, I haven't reported the other problem as a separate bug yet because my system is currently a hybrid of Slackware 14.2 and -current, and I don't know whether it's a general problem or it's caused by my breaking something when upgrading ncurses to the version in -current.) |
David Lawrence Ramsey <dolorous> |
Tue 06 Nov 2018 01:16:44 AM UTC, comment #1: The attached patch, against git 362965b, should fix this, and also make Shift-Delete act as Backspace when the former is read as an escape sequence, whether nano's built with --enable-tiny or not.
|
David Lawrence Ramsey <dolorous> |
Sun 04 Nov 2018 10:52:43 AM UTC, original submission:
To reproduce, run 'nano --ignore --rebindkeypad +12 NEWS' and type <Shift+Delete>. Nano doesn't recognize the sequence. |
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-11-12 | bens | Open/Closed | Open | Closed | |
2018-11-07 | bens | Status | In Progress | Fixed | |
2018-11-07 | dolorous | Attached File | - | Added 0001-input-recognize-escape-sequences-for-Shift-Delete.patch, #45377 | |
2018-11-06 | bens | Status | None | In Progress | |
Assigned to | None | dolorous | |||
2018-11-06 | dolorous | Attached File | - | Added 0001-input-recognize-escape-sequences-for-Shift-Delete.patch, #45366 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Done. (I know that the patch should be as small as possible. However, you also said you didn't like splitting up the NANO_TINY #ifdef, but I can't think of another way to fix it without doing the latter.)