bugGNU Octave - Bugs: bug #54881, dev octave fails to build for...

 
 

bug #54881: dev octave fails to build for windows

Submitter:  John Donoghue <lostbard>
Submitted:  Mon 22 Oct 2018 08:29:39 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  JohnD Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 24 Oct 2018 01:03:45 PM UTC, comment #5: 

That fixed it

John Donoghue <lostbard>
Group Member
Tue 23 Oct 2018 09:05:25 PM UTC, comment #4: 
John W. Eaton <jwe>
Group administrator
Tue 23 Oct 2018 03:55:35 PM UTC, comment #3: 

With patch, next issue(s) cross compiling for windows:


libgui/graphics/.libs/libgui_graphics___init_qt___la-annotation-dialog.o: In function `octave::resource_manager::get_settings()':
/home/johnd/mxe-octave/build-64/tmp-default-octave/octave-5.0.0/libgui/src/resource-manager.h:55: undefined reference to `octave::resource_manager::instance_ok()'
/home/johnd/mxe-octave/build-64/tmp-default-octave/octave-5.0.0/libgui/src/resource-manager.h:55: undefined reference to `octave::resource_manager::do_get_settings() const'
/home/johnd/mxe-octave/build-64/tmp-default-octave/octave-5.0.0/libgui/src/resource-manager.h:55: undefined reference to `octave::resource_manager::instance_ok()'
/home/johnd/mxe-octave/build-64/tmp-default-octave/octave-5.0.0/libgui/src/resource-manager.h:55: undefined reference to `octave::resource_manager::do_get_settings() const'
libgui/graphics/.libs/libgui_graphics___init_qt___la-annotation-dialog.o:annotation-dialog.cc:(.rdata$.refptr._ZN6octave16resource_manager8instanceE[.refptr._ZN6octave16resource_manager8instanceE]+0x0): undefined reference to `octave::resource_manager::instance'



John Donoghue <lostbard>
Group Member
Mon 22 Oct 2018 09:00:58 PM UTC, comment #2: 

I imagine your patch should be fine.  Pushed here:

  http://hg.savannah.gnu.org/hgweb/octave/rev/2201f82db233

I'm not sure why I didn't see a declaration problem with my Debian build.

John W. Eaton <jwe>
Group administrator
Mon 22 Oct 2018 08:52:50 PM UTC, comment #1: 

Patch (as yet untested)



(file #45260)

John Donoghue <lostbard>
Group Member
Mon 22 Oct 2018 08:29:39 PM UTC, original submission:  

Error in mxe-octave, trying to compile lastest commits of dev octave:

tmp-default-octave/octave-5.0.0/libgui/src/main-window.cc:2769:25: error: 'QStyleFactory' has not been declared
     m_qt_app->setStyle (QStyleFactory::create ("Windows"));
                         ^~~~~~~~~~~~~

From changeset http://hg.savannah.gnu.org/hgweb/octave/rev/ceb508ea92ee


So it needs #include <QStyleFactory>  added

John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45260:  54881.patch added by lostbard (683B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  • -email is unavailable- added by lostbard
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-10-24 lostbard StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-10-22 jwe Item GroupInaccurate Result Build Failure
        StatusNone Ready For Test
        Operating SystemAny Microsoft Windows
    2018-10-22 lostbard Attached File- Added 54881.patch, #45260
    2018-10-22 lostbard Carbon-Copy- Added jwe

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code