bugGNU roff - Bugs: bug #54812, [PATCH] BuildFoundries.pl: Add the...

 
 

bug #54812: [PATCH] BuildFoundries.pl: Add the path for searching fonts to a message

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Wed 10 Oct 2018 12:19:49 AM UTC
   
 
Category:  Font devpdf Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  deri
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 01 Apr 2023 03:01:08 PM UTC, comment #5: 


commit d03f7e74fe7deeb0a6408f8027d5789ad75c555b
Author: Deri James <deri@chuzzlewit.myzen.co.uk>
Date:   Wed Oct 17 16:18:56 2018 +0100

    Savannah bug # 54812

    * font/devpdf/util/BuildFoundries.pl: If a font is not found
    report list of paths searched.

    Fix https://savannah.gnu.org/bugs/?54812


G. Branden Robinson <gbranden>
Group administrator
Wed 17 Oct 2018 03:22:41 PM UTC, comment #4: 

Fixed in commit d03f7e74fe7deeb0a6408f8027d5789ad75c555b

Deri James <deri>
Group Member
Sat 13 Oct 2018 04:14:01 PM UTC, comment #3: 

I shall be dealing with this soon. Since the most likely scenario for this warning is when looking for the URW fonts for the U foundry, if the URW fonts are not installed then all the fonts will be warned as "not found”, so I intend to leave the warning as it is but include an extra message at the end if any fonts are not found. This extra message will document the paths searched. This is to avoid being too verbose when many fonts are not found.

Deri James <deri>
Group Member
Fri 12 Oct 2018 10:52:12 PM UTC, comment #2: 


  I have used a tab to show that a _new sentence_ belongs to the first
sentence, and thus all intended following lines belong to the same
diagnostic message.

  In this case there is only one sentence, so I do not find a tab
necessary for clarity.

  But using a tab is no obstacle in my view.


Bjarni Ingi Gislason <bjarniig>
Wed 10 Oct 2018 02:13:13 AM UTC, comment #1: 

I generally dislike multi-line diagnostics, but in this case they may be unavoidable.  In this scenario I would have "\n\t" instead of just "\n", to indent the (probably lengthy) $foundrypath.

G. Branden Robinson <gbranden>
Group administrator
Wed 10 Oct 2018 12:19:49 AM UTC, original submission:  


From 3599366913d1aa367b7c0283c8ddb9b2963c2c0a Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Wed, 10 Oct 2018 00:12:55 +0000
Subject: [PATCH] BuildFoundries.pl: Add the path for searching fonts to a
 message

  File "font/devpdf/util/BuildFoundries.pl":

  Show the path for searching fonts, when a font is not found.

  A warning is not complete, if the associated data is not shown.

  An example is:

BuildFoundries: warning: line 45: Unable to locate font(s) NimbusSansNarrow-BdOblique,NimbusSanL-BoldCondItal,n019064l.pfb on the given path(s):
/usr/share/ghostscript/9.25/Resource/Init :/usr/share/ghostscript/9.25/lib :/usr/share/ghostscript/9.25/Resource/Font :/usr/share/ghostscript/fonts : /var/lib/ghostscript/fonts :/usr/share/cups/fonts : /usr/share/ghostscript/fonts :/usr/local/lib/ghostscript/fonts : /usr/share/fonts  : /home/bg/git/groff/build/../font/devps : /home/bg/git/groff/build/font/devps

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 font/devpdf/util/BuildFoundries.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/font/devpdf/util/BuildFoundries.pl b/font/devpdf/util/BuildFoundries.pl
index fa1a32c9..30306c9b 100644
--- a/font/devpdf/util/BuildFoundries.pl
+++ b/font/devpdf/util/BuildFoundries.pl
@@ -107,7 +107,7 @@ sub LoadFoundry
                         {
                             $gotf=0;
                             my $fns=join(',',split('!',$r[5]));
-                            Warn("Unable to locate font(s) $fns on the given path(s)");
+                            Warn("Unable to locate font(s) $fns on the given path(s):\n$foundrypath");
                             unlink $gfont;        # Unable to find the postscript file for the font just created by afmtodit
                         }
                     }
--
2.19.1


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by deri (Posted a comment)
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-04-01 gbranden Planned ReleaseNone 1.22.4
    2018-10-17 deri StatusNone Fixed
        Open/ClosedOpen Closed
    2018-10-13 deri Assigned toNone deri

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code