bugGNU Octave - Bugs: bug #53996, [patch] fix compilation in master...

 
 

bug #53996: [patch] fix compilation in master by including the QButtonGroup header

Submitter:  Mayeul C. <mayeulc>
Submitted:  Mon 28 May 2018 06:14:38 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Duplicate Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 28 May 2018 07:25:06 AM UTC, comment #1: 

Thank you for the report and the patch. This is a duplicate of bug #53978, which is already fixed on Octave's stable branch with

https://hg.savannah.gnu.org/hgweb/octave/rev/cdaa884568b1

Mike Miller <mtmiller>
Group Member
Mon 28 May 2018 06:14:38 AM UTC, original submission:  

This is a trivial fix that was needed for me after I cloned the repository. QButtonGroup is used line 302 of this file, but the header was not included, leading to an incomplete type error.


diff -r 39cf8145405f libgui/src/settings-dialog.cc
--- a/libgui/src/settings-dialog.cc     Wed May 16 21:36:27 2018 +0200
+++ b/libgui/src/settings-dialog.cc     Mon May 28 08:10:16 2018 +0200
@@ -41,6 +41,7 @@
 #include <QHash>
 #include <QMessageBox>
 #include <QTextCodec>
+#include <QButtonGroup>

 #if defined (HAVE_QSCINTILLA)
 #  include "octave-qscintilla.h"


Mayeul C. <mayeulc>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by mayeulc (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-05-28 mtmiller StatusNone Duplicate
        Open/ClosedOpen Closed
        Dependencies- Depends on bugs #53978

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code