bugGNU Octave - Bugs: bug #53640, editor find shortcuts do not work

 
 

bug #53640: editor find shortcuts do not work

Submitter:  John Donoghue <lostbard>
Submitted:  Fri 13 Apr 2018 01:47:05 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  JohnD Open/Closed:  * Closed
Release:  * 4.3.90 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 13 Apr 2018 05:08:14 PM UTC, comment #5: 

Awesome.  The patch works for me.  I pushed it here http://hg.savannah.gnu.org/hgweb/octave/rev/e74d85f7ac47.

Marking as fixed and closing report.

Rik <rik5>
Group administrator
Fri 13 Apr 2018 04:54:55 PM UTC, comment #4: 

Give the attached changeset a try.

(file #43916)

Dan Sebald <sebald>
Fri 13 Apr 2018 04:02:54 PM UTC, comment #3: 

I'm not seeing...  Ah!  It's when the Documentation window is docked that the Editor is losing those shortcut keys.  When both the features are floated, Editor gets its shortcuts back (on linux).  I'll look at the context of these settings


    QShortcut *show_shortcut = new QShortcut (QKeySequence (QKeySequence::Find), browser_find);
    show_shortcut->setContext(Qt::WindowShortcut);


in terms of docked and undocked state...

Dan Sebald <sebald>
Fri 13 Apr 2018 03:30:56 PM UTC, comment #2: 

It might be useful to try building versions of Octave on the stable branch before one of these two changesets


changeset:   25155:17387d4edd1d
branch:      stable
user:        Daniel J Sebald <daniel.sebald@ieee.org>
date:        Thu Apr 05 11:35:58 2018 -0500
summary:     Add standard key bindings and actions to in-page Documentation find (bug #53006)

changeset:   25121:9578133ca03e
branch:      stable
user:        Daniel J Sebald <daniel.sebald@ieee.org>
date:        Tue Apr 03 20:17:42 2018 -0500
summary:     Add a Ctrl+F unhide/hide in-page find footer to the Documentation window (bug #53006)


I think they are the most likely to have interfered with the shortcuts of the editor.

Rik <rik5>
Group administrator
Fri 13 Apr 2018 02:21:49 PM UTC, comment #1: 

I can confirm on linux (debian stretch). Only the actions in the editor's "Edit" menu are affected.

Pantxo Diribarne <pantxo>
Group Member
Fri 13 Apr 2018 01:47:05 PM UTC, original submission:  

Not sure of Linux, but in windows, in the editor window,
pressing ctrl-F, F3, shift F3 (search options) appear to do nothing.

The editor menus themselves work ok.

I checked the shortcut settings and they look correct.


John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-13 rik5 StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2018-04-13 sebald Attached File- Added octave-documentation_shortcut_context_fine_tune-djs2018apr13.patch, #43916
    2018-04-13 pantxo StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code