bugGNU Octave - Bugs: bug #53506, qp uses fix tolerance: ignores sqp...

 
 

bug #53506: qp uses fix tolerance: ignores sqp tolerance argument

Submitter:  Juan Pablo Carbajal <juanpi>
Submitted:  Wed 28 Mar 2018 08:04:16 PM UTC
 
Category:  Octave Function Severity:  4 - Important
Priority:  5 - Normal Item Group:  Inaccurate Result
Status:  Fixed Assigned to:  None
Originator Name:  juanpi Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Mon 31 Dec 2018 07:32:49 PM UTC, comment #2: 

There isn't enough time to have this be included for the 5.0 release, but I did push the change to the development branch that will become 6.0.  See https://hg.savannah.gnu.org/hgweb/octave/rev/d4211810202a.

I think qp and sqp in general could use an overhaul.  I filed another bug report about the questionable use of rtol as both an absoloute and relative tolerance.  See bug #55351, "qp algorithm needs to distinguish TolX from TolCon".

Marking this bug as fixed and closing report.

Rik <rik5>
Project Administrator
Fri 04 May 2018 04:20:19 PM UTC, comment #1: 

I added the tolerance as an input parameter for qp in _qp_.cc.
The options struct passed to qp.m now  includes "TolX". Until now it contained only maxit.
Regarding sqp.m, he qp subproblem now accepts the tolerance passed to sqp as a parameter.

(file #44091)

Maor Shutman <maors>
Wed 28 Mar 2018 08:04:16 PM UTC, original submission:  

Bug #53483 indicated a problem in sqp which is track down to the C++ code of qp.cc

In line 99 qp uses a fixed tolerance for the search given by sqrt(eps). http://octave.org/doxygen/4.3/da/dbd/____qp_____8cc_source.html

This is a bug in qp and one would need to pass the tolerance as a parameter (or compute the correct tolerance for qp based on the arguments of sqp).
This bug is similar to feature request #43030

Juan Pablo Carbajal <juanpi>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #44091:  53506.cset added by maors (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by maors (Updated the item)
  • -email is unavailable- added by juanpi (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-12-31 rik5 StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2018-05-04 maors Attached File- Added 53506.cset, #44091

    Back to the top


    Powered by Savane 3.9