bugGNU Octave - Bugs: bug #53490, Regression reported for acos,...

 
 

bug #53490: Regression reported for acos, acosh, asin, and asinh on Windows, even though they aren't

Submitter:  John W. Eaton <jwe>
Submitted:  Tue 27 Mar 2018 07:29:47 PM UTC
   
 
Category:  Test Suite Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  jwe Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 03 Apr 2018 12:38:24 AM UTC, comment #6: 

I tested in a Windows XP VM and I don't get any regressions anymore.  Marking as fixed and closing report.

Rik <rik5>
Group administrator
Mon 02 Apr 2018 03:29:23 AM UTC, comment #5: 

I pushed Markus's patch here (http://hg.savannah.gnu.org/hgweb/octave/rev/b9c62b62f9eb).  Marking as Ready for Test.

Rik <rik5>
Group administrator
Sat 31 Mar 2018 08:49:50 PM UTC, comment #4: 

The attached test avoids the regression warnings on Windows by hitch-hiking the existing duplicated tests for Mac.

(file #43751)

Markus Mützel <mmuetzel>
Group administrator
Thu 29 Mar 2018 11:27:29 PM UTC, comment #3: 

Yes, the actual status is if these tests fail on a GNU/Linux or Unix system, then they are regressions and that should be flagged as a problem. If they fail on macOS or Windows, they are known failures with the system libraries.

I see, you have duplicated test blocks for important tests where you want to require the test to pass on !macOS, but allow it to fail on macOS.

Mike Miller <mtmiller>
Group Member
Thu 29 Mar 2018 10:17:54 PM UTC, comment #2: 

These test fail on Windows because the math library isn't very good.  Either we have to do something heroic, upgrade libm was suggested, or we could follow the strategy I developed for the failing macOS tests.  That is verbose, but not too bad.

I suppose the reason to fix them is really because it will alarm people when they do _run_test_suite_ and see these as regressions, when, in fact, they have always been present on Windows machines.

Rik <rik5>
Group administrator
Tue 27 Mar 2018 08:47:00 PM UTC, comment #1: 

Reading the last few comments on bug #45507, I don't think these tests ever passed on Windows. The output you pasted here looks identical to the output in the most recent comments on that bug report.

We added a runtime condition to skip these tests on macOS, should we do the same with ispc? We do want this test to report as a regression if it fails on GNU/Linux systems with a working math library.

Mike Miller <mtmiller>
Group Member
Tue 27 Mar 2018 07:29:47 PM UTC, original submission:  

I'm seeing the following regressions with the 64-bit Windows build (w64, 32 bit Fortran integers, though I expect the result doesn't depend on that).

I used a binary created by the buildbot on a Windows 10 system.



>>>>> processing tests\libinterp\corefcn\mappers.cc-tst

***** testif ; ! ismac ()   <*45507>
 x = [1, -1, i, -i] .* 1e150;
 v = [0, pi, pi/2, pi/2];
 assert (real (acos (x)), v);
!!!!! regression: http://octave.org/testfailure/?45507
ASSERT errors for:  assert (real (acos (x)),v)

  Location  |  Observed  |  Expected  |  Reason
    (1)         1.5708         0         Abs err 1.5708 exceeds tol 0 by 2
    (2)         1.5708       3.1416      Abs err 1.5708 exceeds tol 0 by 2

***** testif ; ! ismac ()   <*45507>
 x = [1, -1, i, -i] .* 1e150;
 v = [0, pi, pi/2, -pi/2];
 assert (imag (acosh (x)), v);
!!!!! regression: http://octave.org/testfailure/?45507
ASSERT errors for:  assert (imag (acosh (x)),v)

  Location  |  Observed  |  Expected  |  Reason
    (4)           -0        -1.5708      Abs err 1.5708 exceeds tol 0 by 2

***** testif ; ! ismac ()   <*45507>
 x = [1, -1, i, -i] .* 1e150;
 v = [pi/2, -pi/2, 0, -0];
 assert (real (asin (x)), v);
!!!!! regression: http://octave.org/testfailure/?45507
ASSERT errors for:  assert (real (asin (x)),v)

  Location  |  Observed  |  Expected  |  Reason
    (1)           0          1.5708      Abs err 1.5708 exceeds tol 0 by 2
    (2)           0         -1.5708      Abs err 1.5708 exceeds tol 0 by 2

***** testif ; ! ismac ()   <*45507>
 x = [1, -1, i, -i] .* 1e150;
 v = [0, 0, pi/2, -pi/2];
 assert (imag (asinh (x)), v);
!!!!! regression: http://octave.org/testfailure/?45507
ASSERT errors for:  assert (imag (asinh (x)),v)

  Location  |  Observed  |  Expected  |  Reason
    (4)           0         -1.5708      Abs err 1.5708 exceeds tol 0 by 2


John W. Eaton <jwe>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43751:  bug53490_mappers_BIST.patch added by mmuetzel (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by jwe (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-03 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-04-02 rik5 StatusConfirmed Ready For Test
    2018-03-31 mmuetzel Attached File- Added bug53490_mappers_BIST.patch, #43751
    2018-03-29 rik5 CategoryOctave Function Test Suite
        Severity4 - Important 3 - Normal
        Item GroupRegression Unexpected Error or Warning
        StatusNone Confirmed
        SummaryRegression for acos, acosh, asin, and asinh on Windows Regression reported for acos, acosh, asin, and asinh on Windows, even though they aren't

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code