bugphpGroupWare - Bugs: bug #5328, "default" template set...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #5328: "default" template set name confusing with U/D/F prefs - solution included

Submitted by:  Michael Totschnig <totschnig>
Submitted on:  Tue 16 Sep 2003 02:32:33 AM UTC  
 
Item Group: SVN trunk (dev code)Category: API - Preferences
Severity: 3 - NormalPriority: 5 - Normal
Status: PostponedPrivacy: Public
Assigned to: Dave Hall <skwashd>Open/Closed: Closed
Component Version: NoneOperating System: None
Reproducibility: NonePlanned Release: None
Fixed Release: 

Sun 04 Dec 2005 09:54:41 AM UTC, comment #5:

The suggested fix has been implemnted in HEAD to solve this issue.

This should have been closed ages ago

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Fri 19 Sep 2003 09:22:00 AM UTC, comment #4:

I have made a major change to the function in cvs. Please test it, I did some testing and it worked.

I have changed the description to just cover point 2 :)

Cheers

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Wed 17 Sep 2003 12:56:53 AM UTC, comment #3:

Maybe it might be even better to get rid of function verify_basic_settings, and implement the same feature in a safer way in function read_repository.

Michael Totschnig <totschnig>
Tue 16 Sep 2003 02:13:39 PM UTC, comment #2:

1) I am not sure what effect array_merge will have. I think, if there is a default value set by the administrator for some setting, phpgroupware must not set a value for this setting in the user's preferences.

2) this sounds reasonable

Michael Totschnig <totschnig>
Tue 16 Sep 2003 05:45:29 AM UTC, comment #1:

1 There are 2 possibilities for solving this one:

  • array_merge() the 2 sets of values - quickest to implement
  • any sysadmin could be unset() in the app defaults array

Any "preference"? :)

2 I agree about the template set name. Maybe a name like "basic" or "simple" would be more accurate. At the same time I think we should keep the current */template/default dirs, just not display them in the available set. This involves little work a couple of minor changes and then the "default" dir a real fallback default directory, which will still function as it does now. I will propose this on the dev list for further discussion. I don't think this can be changed in 16, but should be done in HEAD and available in the next major release, because of the impact of it.

Cheers

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Tue 16 Sep 2003 02:32:33 AM UTC, original submission:

1) When an administrator sets default values in preferences, it is probably because he thinks these values will automatically be valid for new users. But this is not the case, since phpgroupware sets its own default values (in function verify_basic_settings) for new users that have not set there preferences which overide the default values the administrator provided.
2) In Preferences -> Change your settings -> Interface/Template selection the coexistence between the option "Use default" (the administrator set value) and "default" (the template set which is so called) is confusing . It would be better to rename the "default" template set.

Michael Totschnig <totschnig>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 8 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sun 04 Dec 2005 09:54:41 AM UTCskwashdSeverity1,5=>3 - Normal
  Priority2=>5 - Normal
  Open/ClosedOpen=>Closed
Fri 19 Sep 2003 09:22:00 AM UTCskwashdPriority100(Error - Not Found)=>(Error - Not Found)
  StatusNone=>(Error - Not Found)
  Summarypreferences usability issues=>
Fri 19 Sep 2003 09:21:59 AM UTCskwashdItem Group0.9.16RC1=>(Error - Not Found)
Tue 16 Sep 2003 05:45:29 AM UTCskwashdAssigned toNone=>NA

Back to the top


Powered by Savane 3.1-cleanup1