bugGNU nano - Bugs: bug #52967, 'visible whitespace' should not...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52967: 'visible whitespace' should not apply to "Save modified buffer?"

Submitter:  Andreas Schamanek <aschamanek>
Submitted:  Wed 24 Jan 2018 08:27:35 PM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Jump to the original submission

Tue 30 Jan 2018 09:55:20 AM UTC, comment #7: 

Fix has been released in 2.9.3.  Thanks for reporting.

Benno Schulenberg <bens>
Group administrator
Fri 26 Jan 2018 06:29:46 PM UTC, comment #6: 

I think it's a great idea to call display_string() on the filename!

I fetched commit 97cbbb0c and I am currently running it without problems. I'll promise I'll shout loud enough in the unexpected case of facing problems.

Thanks for the super quick fixes, as ever!

Andreas Schamanek <aschamanek>
Fri 26 Jan 2018 08:41:42 AM UTC, comment #5: 

Thanks for testing.  An improved patch (one that includes a replacement fix for bug #49934) has been pushed to master, commit 97cbbb0c.

Benno Schulenberg <bens>
Group administrator
Thu 25 Jan 2018 03:11:24 PM UTC, comment #4: 

Applied patch from comment #3, works for me AFAICS.
Thanks a lot!

Andreas Schamanek <aschamanek>
Thu 25 Jan 2018 09:59:50 AM UTC, comment #3: 

Attached patch should fix the bug.  (It also occurred when doing interactive replacements with visible whitespace turned on.)

(file #43071)

Benno Schulenberg <bens>
Group administrator
Thu 25 Jan 2018 08:56:03 AM UTC, comment #2: 

The offending commit is 99733666, which was meant to fix bug #49934.  It does fix that bug, but... it introduces visible whitespace in several prompts.  For example, when you run 'nano NEWS' and then type: M-P ^O xxx <Enter>.  The "Save under a different name?" prompt also has visible whitespace.

Benno Schulenberg <bens>
Group administrator
Thu 25 Jan 2018 08:39:06 AM UTC, comment #1: 

Thank you for finding and reporting this.  A quick check shows that also 2.8.7 and 2.7.5 are affected.  But 2.4.3, 2.5.3, and 2.6.3 are fine.  Starting  a bisect...

Benno Schulenberg <bens>
Group administrator
Wed 24 Jan 2018 08:27:35 PM UTC, original submission:  

When I edit a file and then press C-X, nano asks "Save modified buffer? ...", but when 'whitespace' is enabled, e.g. by means of M-P, the messages is shown with dots for whitespace, too:

  Save·modified·buffer?··(Answering·"No"·will·DISCARD·changes.)·

Affected: At least 2.9.2 + 2.9.3-pre1
O/S: Debian 8

Note: I haven't yet found other messages that are affected, like "File Name to Write: ", "Search: " or the help screen.

Andreas Schamanek <aschamanek>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by aschamanek (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-30 bens Open/ClosedOpen Closed
    2018-01-26 bens StatusIn Progress Fixed
        Summary'whitespace' should not apply to &quot;Save modified buffer?&quot; 'visible whitespace' should not apply to "Save modified buffer?"
    2018-01-25 bens Attached File- Added convert-the-name-in-the-right-place.patch, #43071
        StatusNone In Progress
    2018-01-25 bens Assigned toNone bens

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code