bugPSPP - Bugs: bug #52831, Windows: File selection dialog...

 
 

bug #52831: Windows: File selection dialog does not show correct folder icons - Adwaita icon theme is only partly installed

Submitted by:  Friedrich Beckmann <beckmanf>
Submitted on:  Sun 07 Jan 2018 07:21:09 PM UTC  
 
Category:  Graphical User Interface Severity:  5 - Average
Status:  Ready for Test/Review Assigned to:  None
Open/Closed:  Open Release:  None
Effort:  0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 09 Jan 2018 08:56:08 PM UTC, comment #1:

Thanks for pointing this out.

I added parts of the Adwaita theme so the folder icons are shown correctly in the latest test.

As far as I can see I have all the necessary icons now. If still see some differences please let me know.

I guess the bug can be closed now.

Harry Thijssen <unknown_one>
Sun 07 Jan 2018 07:21:09 PM UTC, original submission:

Hi Harry,

i digged a little bit deeper into the file selection dialog on Windows. The folder icons are not shown correctly in the file selection dialog. This is due to a partly installed Adwaita icon theme. I copied the Adwaita icon theme from the MacOS installation to the Windows installation and it looks much better. This has nothing to do with the .sav file filter problem. I tested this on Windows 7 with your GNU pspp 1.1.0-g0f447c

You can see that with the full Adwaita icon theme the folder icons are displayed in a correct way while there is no folder indication for the current installation.

I attached two screen shots with the currently installed Adwaita icon theme and the full one that I copied from MacOS. I guess you should include the full Adwaita icon theme in your installation. I think the MacOS Adwaita icon theme version is 3.24.0

Fritz

Friedrich Beckmann <beckmanf>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #42865:  pspp-win-file-sel-with-full-adwaita-icon-theme.JPG added by beckmanf (218KiB - image/jpeg - The file selection dialog on Windows with current Adwaita icon theme installation vs. the copied full installation from MacOS. The icon.zip file is the icon folder in the share directory copied from the Mac installation.)
file #42866:  pspp-win-file-selection-buggy-folder-display.JPG added by beckmanf (224KiB - image/jpeg - The file selection dialog on Windows with current Adwaita icon theme installation vs. the copied full installation from MacOS. The icon.zip file is the icon folder in the share directory copied from the Mac installation.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by unknown_one (Posted a comment)
  • -email is unavailable- added by beckmanf (Submitted the item)
  • -email is unavailable- added by beckmanf
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    Sun 07 Jan 2018 07:21:09 PM UTC beckmanf Attached File- => Added pspp-win-file-sel-with-full-adwaita-icon-theme.JPG, #42865
        Attached File- => Added pspp-win-file-selection-buggy-folder-display.JPG, #42866
        Carbon-Copy- => Added -email is unavailable-

    Back to the top


    Powered by Savane 3.3