bugGNUstep - Bugs: bug #52730, [GWorkspace] Misc compiler warnings

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52730: [GWorkspace] Misc compiler warnings

Submitted by:  Yavor Doganov <yavor>
Submitted on:  Fri 22 Dec 2017 08:50:53 PM UTC  
 
Category:  Application Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  Riccardo Mottola <rmottola>
Open/Closed:  Closed

Fri 26 Jan 2018 06:50:39 AM UTC, comment #2:

The warnings occur with GUI 0.25.0, just rechecked with 0.26.2 and they are the same. Perhaps you test with Clang and that's why you don't get them?

There is no class NSPopUpMenu so I don't think it's bogus or a false positive.

Yavor Doganov <yavor>
Thu 25 Jan 2018 05:35:38 PM UTC, comment #1:

Yavor - i accepted most of your fixes and actually extended some cleanups once I saw a pattern.
I think that the NSPopUpMenu however is bogus or a false positive, I don't get that warning and the "setTag" is strange, NSPopUpMenu should return an NSMenuItem which responds to tag/setTag

Other fixes happened in the past weeks too, so please try.

Riccardo Mottola <rmottola>
Project MemberIn charge of this item.
Fri 22 Dec 2017 08:50:53 PM UTC, original submission:

The attached patch fixes these compiler warnings:
- @interface of class ‘NSPopUpMenu’ not found
- ‘NSCollectionViewItem’ may not respond to ‘-setTag:’
- logical not is only applied to the left hand side of comparison
- initialization from distinct Objective-C type
- variable ‘is_daemon’ set but not used
- comparison between pointer and zero character constant

About is_daemon in mdextractor.m, perhaps it wasn't intended to be a local variable?

Yavor Doganov <yavor>

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rmottola (Posted a comment)
  • -email is unavailable- added by yavor (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-29 rmottola StatusReady For Test => Fixed
        Open/ClosedIn Test => Closed
    2018-01-25 rmottola StatusNone => Ready For Test
        Assigned toNone => rmottola
        Open/ClosedOpen => In Test
    2017-12-22 yavor Attached File- => Added 0001-Fix-miscellaneous-compiler-warnings.patch, #42707

    Back to the top


    Powered by Savane 3.3