bugGNU nano - Bugs: bug #52718, in current git, the indenting...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52718: in current git, the indenting behavior changes when cursor reaches left edge

Submitter:  Benno Schulenberg <bens>
Submitted:  Thu 21 Dec 2017 08:17:21 PM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Fri 29 Dec 2017 03:55:57 PM UTC, comment #3: 

The second patch was still no good; it broke the first test case -- it seems I barely tested it at all.

A correct fix -- I think -- has been pushed to master, 440a128d.

And cosing, because unreleased.

Benno Schulenberg <bens>
Group administrator
Mon 25 Dec 2017 01:30:06 PM UTC, comment #2: 

Slightly improved version of the patch is attached.

Because if you try this with the first version of the patch:

  src/nano +4,17 NEWS

and type: <Shift+Down> <Shift+Down> <Shift+Tab> <Shift+Tab> <Shift+Down> <Shift+Down> <Tab> <Tab>.

The two Tabs will affect also the "Eta" line, but they shouldn't.

(file #42723)

Benno Schulenberg <bens>
Group administrator
Sun 24 Dec 2017 11:31:44 AM UTC, comment #1: 

Attached is a patch that appears to work during first, quick testing.

(file #42712)

Benno Schulenberg <bens>
Group administrator
Thu 21 Dec 2017 08:17:21 PM UTC, original submission:  

To reproduce, run:

   src/nano +3 NEWS

and type: <Right> <Right> M-A <Down> <Down> <Shift+Tab> <Shift+Tab> <Tab> <Tab>.

Note that the two <Shift+Tab>s unindent a group of three lines, but the <Tab>s forget about the third line.  This is not what the user would wish to see.

Expected behavior: if the first indent/unindent/comment/uncomment action affects a certain group of lines, any subsequent and consecutive indent/unindent/comment/uncomment action should affect the same group of lines.

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-12-29 bens StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2017-12-25 bens Attached File- Added 0001-indenting-keep-affecting-last-line-of-marked-region-.patch, #42723
    2017-12-24 bens Attached File- Added 0001-indenting-keep-affecting-last-line-of-marked-region-.patch, #42712
        StatusNone In Progress
        Assigned toNone bens

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code