bugCompact Disc Input and Control Library - Bugs: bug #52690, API changes in 1.1.0 without...

 
 

bug #52690: API changes in 1.1.0 without soname changes

Submitted by:  Christian Marillat <marillat>
Submitted on:  Tue 19 Dec 2017 08:47:32 AM UTC  
 
Category: APISeverity: 5 - Average
Item Group: libcdioStatus: Fixed
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 19 Dec 2017 09:28:51 AM UTC, comment #1:

Thanks for the report. In commit 1021442 I have updated NEWS to indicate this. If you want to make further corrections or suggestions please do and submit a patch.

As for advance warning about breakage: we are now using semantic versioning https://semver.org/. Changing the minor version indicates a backward incompatible change.

I'm not sure if this was that major to change the major number. I believe there is some room for interpretation in there.

Mention of the API change is in the ChangeLog entry:

2017-11-20 R. Bernstein <rocky@gnu.org>

  • include/cdio/ds.h, lib/driver/device.c, lib/iso9660/iso9660_fs.c,

test/testisocd.c: Reduce memory leaks... remove depricated things in dh.h Note: a reworking of ds.h is needed to handle data which has alloc memory.

But yes, in retrospect this would have been hard to detect that I was referring to an API-breaking change here.

Before a release I post to the libcdio-devel mailing list https://lists.gnu.org/mailman/listinfo/libcdio-devel announcing plans to make a release, what's in the release; I also solicit feedback.

When I get none I assueme everything is okay. So to reduce the chance of this happening I suggest MusicPlayerDaemon subscribe to that mailing list. It is a very low-activity mailing list.

I will post something to the github issue tracker cited.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Tue 19 Dec 2017 08:47:32 AM UTC, original submission:

Hi,

I noticed a build failure with mpd 0.20.13 because cdio_list_free()
uses now 3 parameters when only two parameters was used in 1.0.0

mpd author isn't happy about that :

https://github.com/MusicPlayerDaemon/MPD/issues/173

Nothing is documented in the 1.1.0 changeloh :
https://git.savannah.gnu.org/cgit/libcdio.git/tree/NEWS?h=release-1.1.0

And this is the git commit which broke API compatibility: http://git.savannah.gnu.org/cgit/libcdio.git/commit/?id=73800fc0cd81a735764f79b7f3f957d8a71eb02c

Christian Marillat <marillat>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by marillat (Submitted the item)
  • -unavailable- added by marillat
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 19 Dec 2017 09:28:51 AM UTCrockyStatusNone=>Fixed
      Assigned toNone=>rocky
      Open/ClosedOpen=>Closed
    Tue 19 Dec 2017 08:47:32 AM UTCmarillatCarbon-Copy-=>Added marillat

    Back to the top


    Powered by Savane 3.1-cleanup1