bugGNU nano - Bugs: bug #52689, undo/redo does not show correct...

 
 

bug #52689: undo/redo does not show correct Modified state after a midway save

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Mon 18 Dec 2017 07:24:29 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 21 Dec 2017 06:51:46 PM UTC, comment #2:

Fixed in git, commit dc3618a1.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 19 Dec 2017 06:28:25 PM UTC, comment #1:

See attached patch for a fix that seems to hold water.

(file #42684)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 18 Dec 2017 07:24:29 PM UTC, original submission:

(Original report by Liu Hao: http://lists.gnu.org/archive/html/nano-devel/2017-12/msg00065.html.)

To reproduce, run 'nano --ignore xxx', where xxx is a new file. Then type: aaa ^S bbb M-U.

Note that after the ^S, the "Modified" marker disappears, which is correct. But when pressing M-U, there are two errors. First: the aaabbb is removed as a whole, instead of in two steps. Second: after the complete removal of aaabbb the Modified marker is reset, which is wrong because the state of the file on disk is "aaa".

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 21 Dec 2017 06:51:46 PM UTCbensStatusIn Progress=>Fixed
    Tue 19 Dec 2017 06:28:25 PM UTCbensAttached File-=>Added 0001-text-set-and-reset-the-Modified-state-correctly-when.patch, #42684
      StatusNone=>In Progress
      Assigned toNone=>bens

    Back to the top


    Powered by Savane 3.1-cleanup1