bugGNU Octave - Bugs: bug #52596, makeValidName and makeUniqueStrings

 
 

bug #52596: makeValidName and makeUniqueStrings

Submitter:  Guillaume <gyom>
Submitted:  Wed 06 Dec 2017 10:04:23 AM UTC
   
 
Category:  Octave Function Severity:  1 - Wish
Priority:  3 - Low Item Group:  Feature Request
Status:  Fixed Assigned to:  siko1056
Originator Name:  Guillaume Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 12 Dec 2018 10:13:06 AM UTC, comment #7: 

Thank you Kai and Rik for your help and the thorough cleaning up!

Guillaume <gyom>
Tue 11 Dec 2018 03:01:36 PM UTC, comment #6: 
Kai Torben Ohlhus <siko1056>
Group Member
Sat 08 Dec 2018 03:31:37 PM UTC, comment #5: 

This item really seems like a candidate for 5.0.0 and thank you for your contribution Guillaume.

The problem here seems to be the lack of an easy to apply changeset like I proposed with file #45602.

The +matlab/+lang issue seems to be discussed already and I am fine with it.  Both files work as described by Guillaume and the Matlab docs and if no one protests, I will push it next week.

Kai Torben Ohlhus <siko1056>
Group Member
Fri 07 Dec 2018 10:53:02 AM UTC, comment #4: 

Prompted by Rik's comment #7 in bug #53565, I wonder if these two functions could be considered in time for the 5.0 release?

Guillaume <gyom>
Wed 10 Jan 2018 10:00:58 AM UTC, comment #3: 

I know these are not the most exciting functions but could they be considered for inclusion in core? jwe's input would be useful for a decision about the +matlab namespace.

Guillaume <gyom>
Wed 06 Dec 2017 03:30:58 PM UTC, comment #2: 

Hello Pantxo,

Yes, these files should go in scripts/+matlab/+lang. The +matlab namespace was also discussed on IRC and my understanding was that it was the way to go for compatibility (and keep +octave if and when there are some Octave-specific packages).

Guillaume <gyom>
Wed 06 Dec 2017 02:49:55 PM UTC, comment #1: 

Hey,

Do you have any idea how to handle the namespace here? Would we have to put those files in a +matlab/+lang package?

There has been a discussion about this recently:

http://octave.1599824.n4.nabble.com/matlab-namespace-td4685366.html

Could you comment there?

Pantxo Diribarne <pantxo>
Group Member
Wed 06 Dec 2017 10:04:23 AM UTC, original submission:  

I attach a suggested implementation for matlab.lang.makeValidName and matlab.lang.makeUniqueStrings

https://www.mathworks.com/help/matlab/ref/matlab.lang.makevalidname.html
https://www.mathworks.com/help/matlab/ref/matlab.lang.makeuniquestrings.html

Guillaume <gyom>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45602:  bug52596.cset added by siko1056 (18KiB - application/octet-stream)
file #42576:  makeValidName.m added by gyom (7KiB - text/x-objcsrc)
file #42577:  makeUniqueStrings.m added by gyom (7KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by gyom (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-12-11 siko1056 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-12-08 siko1056 Severity3 - Normal 1 - Wish
        Priority5 - Normal 3 - Low
        StatusPatch Submitted Ready For Test
        Assigned toNone siko1056
    2018-12-08 siko1056 Attached File- Added bug52596.cset, #45602
    2017-12-06 pantxo StatusNone Patch Submitted
    2017-12-06 gyom Attached File- Added makeValidName.m, #42576
        Attached File- Added makeUniqueStrings.m, #42577

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code