bugGNUstep - Bugs: bug #52518, [GWorkspace] Unnecessarily complex...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52518: [GWorkspace] Unnecessarily complex build system

Submitted by:  Yavor Doganov <yavor>
Submitted on:  Sun 26 Nov 2017 07:11:13 PM UTC  
 
Category: ApplicationSeverity: 3 - Normal
Item Group: Change RequestStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Sun 26 Nov 2017 07:15:17 PM UTC, comment #1:

Thinko, I wanted to say "--no-undefined" instead of "--as-needed".

Yavor Doganov <yavor>
Sun 26 Nov 2017 07:11:13 PM UTC, original submission:

GWorkspace's build system is incredibly convoluted: there are 56 (!) nested configure scripts, 14 config headers and 59 makefiles that are generated, while only a small number of them have @something@ to be AC_SUBST'ed. I tried to find out whether there is specific reason for this approach, but couldn't figure out why it was done this way. Perhaps it remained so from Enrico's days and nobody had the chance to clean it up.

The only legitimate reason for using AC_CONFIG_SUBDIRS is when software in sub-directories is distributed as stand-alone packages (e.g., separate self-contained tarballs for the frameworks, extractors, viewers, ddbd and the rest of the tools) That is not the case and I doubt it ever will be.

The attached patch, while rather intrusive, reduces the time for running "./configure --enable-gwmetadata" more than 10 times and reduces the size of the tarball with approx 2.5 MB. It also fixes quotation of Autoconf macros in some places, replaces the obsolete AC_TRY_RUN macro with AC_RUN_IFELSE and fixes the build with LDFLAGS=-Wl,--as-needed.

Please let me know if something doesn't work as expected or if you have some other remarks. Thanks.

Yavor Doganov <yavor>

 

Attached Files
file #42493:  0001-Simplify-build-system.patch.xz added by yavor (49KiB - application/x-xz)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by yavor (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 26 Nov 2017 07:11:13 PM UTCyavorAttached File-=>Added 0001-Simplify-build-system.patch.xz, #42493

    Back to the top


    Powered by Savane 3.1-cleanup1