bugCompact Disc Input and Control Library - Bugs: bug #52495, libcdio-1.0.0 compilation fails...

 
 

bug #52495: libcdio-1.0.0 compilation fails with --enable-cddb

Submitted by:  Bernard Cafarelli <voyageur>
Submitted on:  Fri 24 Nov 2017 03:26:42 PM UTC  
 
Category: compilationSeverity: 5 - Average
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 24 Nov 2017 03:38:10 PM UTC, comment #1:

Thanks for the bug report and patched.

It should now be applied in commit a5cd2ff

Also thanks for packaging in Gentoo.

Which reminds me, you might be interested in the other fix since this release, setting LIBCDIO_VERSION_NUM in a sane manner.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Fri 24 Nov 2017 03:26:42 PM UTC, original submission:

Related commit: b3d08d90c59b2b638557201599ca38f1bb1070a4

Some shadowed variables were "hidden" under HAVE_CDDB, so 1.0.0 compilation fails:
/bin/sh ../libtool --tag=CC --mode=link x86_64-pc-linux-gnu-gcc -march=skylake -O2 -pipe -Wall -Wbad-function-cast -Wcast-align -Wchar-subscripts -Wdeclaration-after-statement -Wdisabled-optimization -Wendif-labels -Winline -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wno-sign-compare -Wpointer-arith -Wshadow -Wstrict-prototypes -Wundef -Wunused -Wwrite-strings -Wl,-O1 -Wl,--as-needed -o mmc-tool mmc-tool.o util.o getopt.o getopt1.o ../lib/iso9660/libiso9660.la ../lib/driver/libcdio.la -lm
../../libcdio-1.0.0/src/cdda-player.c: In function ‘get_cddb_disc_info’:
../../libcdio-1.0.0/src/cdda-player.c:534:60: error: ‘i_first_track’ undeclared (first use in this function); did you mean ‘i_last_track’?
b_db = init_cddb(p_cdio, &p_conn, &p_cddb_disc, xperror, i_first_track,
^~~~~~~~~~~~~
i_last_track
../../libcdio-1.0.0/src/cdda-player.c:534:60: note: each undeclared identifier is reported only once for each function it appears in
../../libcdio-1.0.0/src/cdda-player.c:535:20: error: ‘i_tracks’ undeclared (first use in this function); did you mean ‘_tracef’?
i_tracks, &i_cddb_matches);
^~~~~~~~
_tracef
../../libcdio-1.0.0/src/cdda-player.c: In function ‘get_cddb_track_info’:
../../libcdio-1.0.0/src/cdda-player.c:834:51: error: ‘i_first_track’ undeclared (first use in this function); did you mean ‘i_last_track’?
i_track - i_first_track);
^~~~~~~~~~~~~
i_last_track

Using the renamed *_global variables works, fix attached

Downstream bug: https://bugs.gentoo.org/638576

Bernard Cafarelli <voyageur>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by voyageur (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 24 Nov 2017 03:38:10 PM UTCrockyStatusNone=>Fixed
      Assigned toNone=>rocky
    Fri 24 Nov 2017 03:26:42 PM UTCvoyageurAttached File-=>Added libcdio-1.0.0-cddb_compile.patch, #42469

    Back to the top


    Powered by Savane 3.1-cleanup1