bugGNU troff - Bugs: bug #52433, Commit [09040dbf] is wrong

 
 

bug #52433: Commit [09040dbf] is wrong

Submitted by:  None
Submitted on:  Fri 17 Nov 2017 06:51:01 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenPlanned Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 17 Nov 2017 06:51:01 PM UTC, original submission:

I am here for something else, the commit mentioned changed

- if ((*t)->buffer[j] == INLINE_LEADER_CHAR) {
+ if (j < char_block::SIZE && (*t)->buffer[j] == INLINE_LEADER_CHAR) {

where it should have been

+ if (j < (t)->used && (t)->buffer[j] == INLINE_LEADER_CHAR) {

instead. But better would be redoing the entire thing, if that
comment is allowed, including indentation fixes. Note especially
that, if all the buffer of t consumed, and t stepped to next
buffer, an array index of that next *t with this j is
performed. That cannot be correct?

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

No Changes Have Been Made to This Item

Back to the top


Powered by Savane 3.1-cleanup1