bugGNU Octave - Bugs: bug #52397, [mxe-octave] ...

 
 

bug #52397: [mxe-octave] of-image-1-fixes.patch is obsolete with image 2.6.2

Submitted by:  Avinoam Kalma <avinoam>
Submitted on:  Mon 13 Nov 2017 05:18:11 AM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: AvinoamOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 15 Nov 2017 04:35:09 AM UTC, comment #2:

John D has fixed this in http://hg.octave.org/mxe-octave/rev/4e0d5c846b7b.

Closing as fixed

Avinoam Kalma <avinoam>
Project Member
Mon 13 Nov 2017 05:37:06 PM UTC, comment #1:

The file src/of-image-1-fixes.patch fixes two different things. One of them is enabling the build in Octave 4.3. That issue is addressed with the image package release 2.6.2 and should be removed once mxe-octave is updated to the latest image package.

However, it also patches out bug #50153 in bwperim. This patch has been applied in the default branch of the image package, to be part of the next minor (not patch) release. I don't quite understand why that one change was singled out to be included in mxe-octave. If mxe-octave wants to include unreleased changes, I think it's better that it includes patches from the stable branch only. Unless there's a reason why that bug fix on bwperim needs to be included, I think it should be removed too.

A separate note, may be a good idea to separate patches with different purposes in different files.

Carnë Draug <carandraug>
Project Member
Mon 13 Nov 2017 05:18:11 AM UTC, original submission:

After the release of image-2.6.2, of-image-1-fixes.patch should be removed. It causes build failure when building MXE-Octave with 2.6.2

Avinoam Kalma <avinoam>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 15 Nov 2017 04:35:09 AM UTCavinoamStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 13 Nov 2017 05:37:06 PM UTCcarandraugSummary[mxe-octave] of-image-1-fixes.patch is obsolete=>[mxe-octave] of-image-1-fixes.patch is obsolete with image 2.6.2

    Back to the top


    Powered by Savane 3.1-cleanup1