GNU nano - Bugs: bug #52392, inserting a DOS or Mac file will...
You are not allowed to post comments on this tracker with your current authentication level.
bug #52392: inserting a DOS or Mac file will set that format for the current file too
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Sat 11 Nov 2017 10:56:05 AM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | dolorous | Open/Closed: | Closed |
Mon 13 Nov 2017 07:06:44 PM UTC, comment #5: |
Benno Schulenberg <bens> |
Sun 12 Nov 2017 09:25:27 PM UTC, comment #4: Attached a third version that builds properly with --enable-tiny; I forgot the second set of #ifdefs in the last version. |
David Lawrence Ramsey <dolorous> |
Sun 12 Nov 2017 07:37:36 PM UTC, comment #3: Thanks for the feedback. Attached a second version that uses ISSET(MULTIBUFFER) and does so in do_insertfile() (and doesn't drop the Mac format from the es.gmo file). |
David Lawrence Ramsey <dolorous> |
Sun 12 Nov 2017 06:55:39 PM UTC, comment #2: Thanks for the patch. But when running src/nano --ignore --multi, and then typing ^R po/es.gmo <Enter>, it drops the Mac format from the es.gmo file. I think it should '!ISSET(MULTIBUFFER)' instead of 'undoable'. And I would have expected this logic in do_insertfile(), but that as an aside. |
Benno Schulenberg <bens> |
Sun 12 Nov 2017 06:09:55 PM UTC, comment #1: The attached patch against git 1e29214 should fix this. (The logic could most likely be consolidated more, but it does work.) |
David Lawrence Ramsey <dolorous> |
Sat 11 Nov 2017 10:56:05 AM UTC, original submission:
To reproduce, run:
|
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-11-19 | bens | Open/Closed | Open | Closed | |
2017-11-13 | bens | Status | In Progress | Fixed | |
2017-11-12 | dolorous | Attached File | - | Added 0001-files-don-t-change-file-format-when-inserting-into-a.patch, #42378 | |
2017-11-12 | dolorous | Attached File | - | Added 0001-files-don-t-change-file-format-when-inserting-into-a.patch, #42377 | |
2017-11-12 | bens | Status | None | In Progress | |
Assigned to | None | dolorous | |||
2017-11-12 | dolorous | Attached File | - | Added 0001-files-don-t-change-file-format-when-inserting-into-a.patch, #42376 |
Powered by Savane 3.13-02a9.
Corresponding source code
Thanks. Fixed in git, 169da094.