bugGNU nano - Bugs: bug #52339, since XDG support in git, nano...

 
 

bug #52339: since XDG support in git, nano cannot find histories in $HOME/.nano

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Sun 05 Nov 2017 06:14:29 PM UTC  
 
Severity: 4 - ImportantStatus: Fixed
Assigned to: David Lawrence Ramsey <dolorous>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 05 Nov 2017 07:45:39 PM UTC, comment #2:

Ouch. That was a silly mistake. I apparently never even "walked" through that line, but simply assumed that it was done right. :|

Fixed in git, 7d653e5a. Thanks for the patch. Tweaked to use positive logic.

Benno Schulenberg <bens>
Project Administrator
Sun 05 Nov 2017 06:17:16 PM UTC, comment #1:

The attached patch against git c16e79b fixes this. The problem is caused by an incorrect return value check in the stat() call in have_statedir(); it should be checking if the directory does exist, not if it doesn't.

(file #42331)

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.
Sun 05 Nov 2017 06:14:29 PM UTC, original submission:

Since support for XDG directories was added to nano in git c16e79b, the fallback code to look for the state directory in $HOME/.nano fails to find it even when it exists, meaning that the XDG directories have to exist or nano cannot save search/replace/execute and file position histories.

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 05 Nov 2017 07:45:39 PM UTCbensSeverity3 - Normal=>4 - Important
      StatusNone=>Fixed
      Assigned toNone=>dolorous
      Open/ClosedOpen=>Closed
    Sun 05 Nov 2017 06:17:16 PM UTCdolorousAttached File-=>Added 0001-history-fix-check-for-existing-HOME-.nano-directory.patch, #42331

    Back to the top


    Powered by Savane 3.1-cleanup1