bugGNU GRUB - Bugs: bug #52311, completion.c:...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52311: completion.c: GRUB_PARSER_STATE_QUOTE is checked twice

Submitter:  AppChecker <appchecker>
Submitted:  Mon 30 Oct 2017 05:47:50 PM UTC
   
 
Category:  Compilation Severity:  Major
Priority:  5 - Normal Item Group:  None
Status:  None Privacy:  Public
Assigned to:  None Originator Name: 
Open/Closed:  Open Release:  Git master
Release:  Reproducibility:  None
Planned Release:  None

Mon 30 Oct 2017 05:47:50 PM UTC, original submission:  

Hi,
in this code fragment (http://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/normal/completion.c?id=446794de8da4329ea532cbee4ca877bcafd0e534#n495):

if (*escstr == ' ' && cmdline_state != GRUB_PARSER_STATE_QUOTE
      && cmdline_state != GRUB_PARSER_STATE_QUOTE)

cmdline_state != GRUB_PARSER_STATE_QUOTE is repeated twice

Probably, is should be:
if (*escstr == ' ' && cmdline_state != GRUB_PARSER_STATE_QUOTE
      && cmdline_state != GRUB_PARSER_STATE_DQUOTE)

This possible defect found by AppChecker (https://npo-echelon.ru/en/solutions/appchecker.php)




AppChecker <appchecker>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by appchecker (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code