bugGNU Octave - Bugs: bug #52250, Building with Qt5 don't use native...

 
 

bug #52250: Building with Qt5 don't use native icons

Submitted by:  Pantxo Diribarne <pantxo>
Submitted on:  Thu 19 Oct 2017 08:14:25 AM UTC  
 
Category:  GUI Severity:  2 - Minor
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 02 Nov 2018 10:27:26 AM UTC, comment #9:

@Torsten: This doesn't occur anymore with linux Mint 19: the correct default icon theme is picked without doing anything. Closing report.

Pantxo Diribarne <pantxo>
Project Member
Tue 31 Oct 2017 11:27:02 AM UTC, comment #8:

Yes, appmenu-Qt5 was installed and uninstalling it makes Icons fall back to Tango theme.
So the difference is that with your patch and appmenu-Qt5 installed:

  • Icons are the ones from my desktop, without having to set "QT_QPA_PLATFORMTHEME=appmenu-qt5" as I had to do before the patch (e.g. for comment #2).
  • The main menu is present and functional
Pantxo Diribarne <pantxo>
Project Member
Sun 29 Oct 2017 10:14:33 PM UTC, comment #7:

Was appmenu-qt5 installed or not during you test?

Torsten <ttl>
Project Member
Sun 29 Oct 2017 11:03:10 AM UTC, comment #6:

With this patch I recover both the native icons and the main menu without having to set any environment variable. So on my desktop this is the perfect behavior but I understand that on Unity (and probably on mac) having the menubar duplicated is not ideal.

Pantxo Diribarne <pantxo>
Project Member
Sat 28 Oct 2017 03:04:58 PM UTC, comment #5:

When I set the main menu bar to non-native, I have the menu bar within the main window and as global menu. Pantxo, could you please test this attached patch on your system?

(file #42284)

Torsten <ttl>
Project Member
Fri 20 Oct 2017 10:58:14 PM UTC, comment #4:

Yes, I guess it should be the task of Cinamon to set the those environment variables so that by default Qt applications look like any other one.

If you think something can be done in Octave it's ok to try, but I am perfectly fine with closing this report as invalid.

Pantxo Diribarne <pantxo>
Project Member
Fri 20 Oct 2017 05:06:02 AM UTC, comment #3:

I am running Ubuntu Unity and there, the editor menu bar disappeared. Thats why this menu bar is set to non-native in changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/6fdbdb66d7cb

I will try to do this for main menu bar, too, but I think then the menu bar will stick within the Octave window and will be available as global menu bar on Mac and Unity.

As far as I know, instead of using the tool qt5ct one can also directly set appropriate values for the related environment variables.

Torsten <ttl>
Project Member
Thu 19 Oct 2017 08:53:37 PM UTC, comment #2:

Indeed using appmenu-qt5 makes me recover the icons but then I loose the main menu bar (the editor menu bar is still there) and the main menu shortcuts like "ctrl+Q" don't work anymore.
Looks line the appmenu QPA was designed for desktops like ubuntu or mac with a native main menu bar.

I found this post [1] than describes very well the issue. In short for versions prior to Qt 5.5 (I have 5.2) it doesn't look like something Octave can do about.

[1] http://www.webupd8.org/2015/11/configure-qt5-application-style-icons.html

Pantxo Diribarne <pantxo>
Project Member
Thu 19 Oct 2017 07:27:37 PM UTC, comment #1:

Hi Pantxo, if I remember correctly, you have to install appmenu-qt5 for getting the correct theme in qt applications.

Torsten <ttl>
Project Member
Thu 19 Oct 2017 08:14:25 AM UTC, original submission:

I just tried to build Octave with Qt5 and all icons have switched to Tango while with Qt4 they used to be "native" icons (i.e. the same monochrome icons I see in other gtk applications) for standard actions such as "open file", "new file" ...

I am on linux mint 17.3.

Pantxo Diribarne <pantxo>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #42284:  bug52250_v1.patch added by ttl (615B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by pantxo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-02 pantxo StatusNone => Fixed
        Open/ClosedOpen => Closed
    2017-10-28 ttl Attached File- => Added bug52250_v1.patch, #42284

    Back to the top


    Powered by Savane 3.3