bugGNU Octave - Bugs: bug #52237, [MXE] Cross-compile for Windows...

 
 

bug #52237: [MXE] Cross-compile for Windows fails with Qt4

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Mon 16 Oct 2017 05:44:08 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 4.2.1Operating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 17 Oct 2017 05:52:37 PM UTC, comment #3:

I pushed the change to stable here: http://hg.savannah.gnu.org/hgweb/octave/rev/7db56856b870
And then merged it to default here: http://hg.savannah.gnu.org/hgweb/octave/rev/8f04d48bb1a0

I agree that the remaining bugs that block Qt 5 should be addressed. I was referring to bug #46910. Should those bugs be increased in priority?
I mostly work on-screen and routinely use screenshots to "save" plots. My knowledge of Octave's printing system is rather rudimentary. But if someone needed help to debug this on Windows, I could definitely try things out.

Markus Mützel <mmuetzel>
Project Member
Mon 16 Oct 2017 07:05:55 PM UTC, comment #2:

Markus - I think it's important that we get Octave working with Qt 5. I think the next major release of Octave official images should be built with Qt 5. So if you think there are major problems, like being unable to print figures, those should be addressed instead of going back to Qt 4.

But I do agree that we should maintain compatibility with Qt 4 where it's easy to do so.

Patch looks simple and good to me.

Mike Miller <mtmiller>
Project Administrator
Mon 16 Oct 2017 05:46:55 PM UTC, comment #1:

The attached patch should be applied to stable and then merged to default.

(file #42166)

Markus Mützel <mmuetzel>
Project Member
Mon 16 Oct 2017 05:44:08 PM UTC, original submission:

Cross-compiling for Windows fails with --disable-qt5.
It looks like QChar::Space didn't exist in Qt4. That was introduced to fix bug #52013. (CC'ing lostbard)
After replacing it with QChar(' '), it compiles without error and the issue in bug #52013 is still fixed.
Since printing figures doesn't work with Qt5-Octave on Windows (at least not for me), we should try and keep Octave compatible with Qt4, imho.

I can provide a patch for this easy fix as soon as I have the bug number.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #42166:  bug52237_win32_qt4.patch added by mmuetzel (919B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by mmuetzel (Submitted the item)
  • -unavailable- added by mmuetzel
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 21 Oct 2017 05:15:17 PM UTCmmuetzelStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 17 Oct 2017 05:52:37 PM UTCmmuetzelStatusPatch Reviewed=>Ready For Test
    Mon 16 Oct 2017 07:05:55 PM UTCmtmillerStatusNone=>Patch Reviewed
    Mon 16 Oct 2017 05:46:55 PM UTCmmuetzelAttached File-=>Added bug52237_win32_qt4.patch, #42166
    Mon 16 Oct 2017 05:44:08 PM UTCmmuetzelCarbon-Copy-=>Added lostbard

    Back to the top


    Powered by Savane 3.1-cleanup1