bugGNU Octave - Bugs: bug #52095, tar, untar, and unpack errors and...

 
 

bug #52095: tar, untar, and unpack errors and incorrect output when TAR_OPTIONS in environment

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Fri 22 Sep 2017 11:30:54 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 24 Sep 2017 08:04:09 PM UTC, comment #3:

Fixed on default

https://hg.savannah.gnu.org/hgweb/octave/rev/8f3db1ac7877

Mike Miller <mtmiller>
Project Administrator
Sun 24 Sep 2017 07:19:26 PM UTC, comment #2:

There are a few other places in the code where we save and restore user environment variables.

I think it's a very good policy to always respect user environment variables and not modify them unless it's absolutely necessary, in a limited scope, as in this case.

Mike Miller <mtmiller>
Project Administrator
Sun 24 Sep 2017 07:16:31 PM UTC, comment #1:

I had no idea there even was such an environment variable. Certainly saving and restoring the variable seems like a reasonable solution. Do we even have to bother restoring? Doesn't Octave always run in its own subprocess and thus can't affect the wider environment? In that case, we could just use this code alone without an unwind_protect block to restore the old value.

Rik <rik5>
Project Administrator
Fri 22 Sep 2017 11:30:54 PM UTC, original submission:

If the user environment variable TAR_OPTIONS is present containing options to pass to the GNU tar command, it may make the tar, untar, and unpack functions fail or output weird results.

For example

or

In these functions, Octave is parsing the output of the tar command and expecting it to behave in very specific ways, so I think it would be best to clear and restore the value of TAR_OPTIONS.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 24 Sep 2017 08:04:09 PM UTCmtmillerStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1