bugGNU Octave - Bugs: bug #52067, dconv2.f out of bound

 
 

bug #52067: dconv2.f out of bound

Submitted by:  Dmitri A. Sergatskov <dasergatskov>
Submitted on:  Wed 20 Sep 2017 05:54:53 AM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Segfault, Bus Error, etc.
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 23 Sep 2017 03:14:05 AM UTC, comment #4:

Thanks. "make check" now passes when octave compiled
with -fbounds-check

(as of 80906ac05e7d tip @)

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Fri 22 Sep 2017 08:56:06 PM UTC, comment #3:

The problem is that the "valid" shape can result in empty matrices. However, the Fortran code was never set up to handle such an input. It assumes that trivial cases like that have been filtered out. I added a test in oct-convn.cc on whether the result matrix dimensions make it empty, and if it is then it short-circuits and returns from the function rather than passing the A and B matrices down to Fortran. See http://hg.savannah.gnu.org/hgweb/octave/rev/88a593fa1388.

Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Fri 22 Sep 2017 06:35:37 PM UTC, comment #2:

Checking through the tests in conv2.cc, the first one that causes the out-of-bounds access is one that uses the 'valid' shape.

Bug #34893 might be relevant. Or possibly bug #39314.

Rik <rik5>
Project Administrator
Wed 20 Sep 2017 04:08:18 PM UTC, comment #1:

I guess I'm not surprised. I hate the convolution function. It is coded in a tricky way and has caused multiple bug reports over the long history that I've been dealing with it.

Rik <rik5>
Project Administrator
Wed 20 Sep 2017 05:54:53 AM UTC, original submission:

I re-compiled octave with FFLAGS=-fbounds-check and the first
test that fails is:

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by dasergatskov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 22 Sep 2017 08:56:06 PM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1