bugGNU Octave - Bugs: bug #52041, imfinfo error when extension...

 
 

bug #52041: imfinfo error when extension specified as second argument

Submitted by:  None
Submitted on:  Fri 15 Sep 2017 01:34:07 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Originator Email: -unavailable-
Open/Closed: ClosedRelease: other
Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 19 Sep 2017 05:41:02 PM UTC, comment #6:

Thanks, sorry I didn't get back to this over the weekend.

Mike Miller <mtmiller>
Project Administrator
Mon 18 Sep 2017 07:53:29 PM UTC, comment #5:

I checked the change in under Mike's name here http://hg.savannah.gnu.org/hgweb/octave/rev/6782105f1820. Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Fri 15 Sep 2017 06:35:52 PM UTC, comment #4:

I created some input validation tests for imfinfo. See the attached 52041.diff. I think you just need to slap on a commit message and submit it. It should go on stable.

(file #41812)

Rik <rik5>
Project Administrator
Fri 15 Sep 2017 05:19:51 PM UTC, comment #3:

I can confirm that the simple change suggested works:

but I would like to add a test case to this. If someone comes up with a test case faster than I can please share it.

Mike Miller <mtmiller>
Project Administrator
Fri 15 Sep 2017 04:10:43 PM UTC, comment #2:

This used to work in Octave 3.8 but was broken sometime before the Octave 4.0 release and has been since. A test case should be added for this calling form as well.

Mike Miller <mtmiller>
Project Administrator
Fri 15 Sep 2017 04:08:03 PM UTC, comment #1:

Confirmed, the imfinfo function uses a local variable "ext" but the function arguments take a varargin.

Mike Miller <mtmiller>
Project Administrator
Fri 15 Sep 2017 01:34:07 PM UTC, original submission:

Bug seems to be on line 157 of imfinfo.m, i.e. replacing

! ischar (ext)

with

! ischar (varargin{1})

seems to work

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41812:  52041.diff added by rik5 (784B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by mtmiller (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 18 Sep 2017 07:53:29 PM UTCrik5StatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Fri 15 Sep 2017 06:35:52 PM UTCrik5Attached File-=>Added 52041.diff, #41812
      StatusConfirmed=>In Progress
    Fri 15 Sep 2017 04:08:03 PM UTCmtmillerCategoryOctave Forge Package=>Octave Function
      Item GroupUnexpected Error=>Incorrect Result
      StatusNone=>Confirmed
      Summaryimage: imfinfo crashes if extension specified=>imfinfo error when extension specified as second argument

    Back to the top


    Powered by Savane 3.1-cleanup1