bugGNU Octave - Bugs: bug #51978, [octave forge] (image) Typo in...

 
 

bug #51978: [octave forge] (image) Typo in unit test for watershed

Submitted by:  Rafael Laboissiere <rlaboiss>
Submitted on:  Sun 10 Sep 2017 02:18:01 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: CarnĂ« Draug <carandraug>
Originator Name: Open/Closed: Closed
Release: otherOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 13 Sep 2017 12:10:26 PM UTC, comment #2:

I have pushed the fix. That test still fails though since we haven't yet figured out what Matlab is doing. For what is worth, Octave's solution is also correct, that test unit is an ill-defined problem.

http://hg.code.sf.net/p/octave/image/rev/617861a926ec

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Wed 13 Sep 2017 04:56:47 AM UTC, comment #1:

This patch fixes the typo, thanks.
(there is a typo in patch summary: noames->names)
Adding package maintainer to CC.

Avinoam Kalma <avinoam>
Project Member
Sun 10 Sep 2017 02:18:01 PM UTC, original submission:

The variables im_full and matlab_result_full in one of the unit tests of function watershed are clearly wrongly named. The path attached below fixes the problem.

Rafael Laboissiere <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by avinoam
  • -unavailable- added by rlaboiss (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 13 Sep 2017 12:10:26 PM UTCcarandraugStatusPatch Reviewed=>Fixed
      Open/ClosedOpen=>Closed
    Wed 13 Sep 2017 04:56:47 AM UTCavinoamStatusNone=>Patch Reviewed
      Assigned toNone=>carandraug
      Carbon-Copy-=>Added -unavailable-
    Sun 10 Sep 2017 02:18:01 PM UTCrlaboissAttached File-=>Added typo-unit-test-watershed.patch, #41775

    Back to the top


    Powered by Savane 3.1-cleanup1