bugGNU Octave - Bugs: bug #51935, Problem with meta.class.fromName

 
 

bug #51935: Problem with meta.class.fromName

Submitted by:  Avinoam Kalma <avinoam>
Submitted on:  Mon 04 Sep 2017 03:07:14 PM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: AvinoamOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 21 Sep 2017 08:57:32 PM UTC, comment #5:

I pushed the changeset here:

http://hg.savannah.gnu.org/hgweb/octave/rev/3645139bd28f

Closing report.

John W. Eaton <jwe>
Project Administrator
Sun 10 Sep 2017 09:33:27 PM UTC, comment #4:

Can anyone check this patch and push it?

Avinoam Kalma <avinoam>
Project Member
Thu 07 Sep 2017 05:56:53 PM UTC, comment #3:

The patch fixed the bug for me, thanks.

Avinoam Kalma <avinoam>
Project Member
Wed 06 Sep 2017 05:20:38 PM UTC, comment #2:

Thanks, I will check test this patch.

Avinoam Kalma <avinoam>
Project Member
Wed 06 Sep 2017 12:44:32 AM UTC, comment #1:

I wrote a few line patch for this problem.

This problem is in pt-eval.cc in function tree_evaluator::visit_index_expression. It's connected to the fact that indexing_object was properly evaluated only before starting the indexing in line 1299. It needs to be evaluated after getting every partial_expr_val.

I also added a test for this problem under test/classdef/classdef.tst.

(file #41740)

Piotr Held <jsoh425>
Mon 04 Sep 2017 03:07:14 PM UTC, original submission:

Octave 4.2.1

Octave 4.3.0+ (hg_id = 21d2114476a4)

Avinoam Kalma <avinoam>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41740:  patch_bug51935.diff added by jsoh425 (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by jsoh425 (Updated the item)
  • -unavailable- added by avinoam (Submitted the item)
  • -unavailable- added by avinoam
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 21 Sep 2017 08:57:32 PM UTCjweStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Wed 06 Sep 2017 05:20:38 PM UTCavinoamStatusNone=>Patch Submitted
    Wed 06 Sep 2017 12:44:32 AM UTCjsoh425Attached File-=>Added patch_bug51935.diff, #41740
    Mon 04 Sep 2017 03:07:14 PM UTCavinoamCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1