bugGNU Octave - Bugs: bug #51905, Variable Editor issues resulting...

 
 

bug #51905: Variable Editor issues resulting from '&' inserted into the tab text by KDE

Submitted by:  Rik <rik5>
Submitted on:  Thu 31 Aug 2017 05:35:51 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 10 Sep 2017 04:04:02 PM UTC, comment #12:

I have pushed the patch with cset
http://hg.savannah.gnu.org/hgweb/octave/rev/ca4ab27152a9

Torsten <ttl>
Project Member
Sun 10 Sep 2017 04:26:22 AM UTC, comment #11:

Yes, each dock widget has an ampersand somewhere unless I set the correct variable in the kdeglobals file.

Rik <rik5>
Project Administrator
Sun 10 Sep 2017 12:01:18 AM UTC, comment #10:

Good, I will push the cset soon.

The window title is directly read by the system, thus there is no way for us to filter something out here. You should see ampersands in the title of each dock widget, is this correct?

Torsten <ttl>
Project Member
Fri 08 Sep 2017 03:26:49 PM UTC, comment #9:

@Torsten: The patch works for me. I removed "AutoCheckAccelerators=false" from my kdeglobals file and I can correctly operate on variables. Please go ahead and commit it.

Can this same strategy be used for the Window Title as well? I still see the title as "&Variable Editor" in the Alt+Tab window. Or maybe there is a way to turn off accelerators for a specific Qt Window so that the Auto-Add feature of KDE is never activated?

Rik <rik5>
Project Administrator
Fri 08 Sep 2017 04:52:23 AM UTC, comment #8:

Please find attached the updated patch ampersand_v02.patch.

(file #41760)

Torsten <ttl>
Project Member
Thu 07 Sep 2017 04:17:27 PM UTC, comment #7:

If I go back to 24013 then the patch applies. The cset that causes the rejections is

which was applied only yesterday.

Rik <rik5>
Project Administrator
Thu 07 Sep 2017 03:57:22 PM UTC, comment #6:

If the problems are due to my recent style changes, then I can help update the patch.

John W. Eaton <jwe>
Project Administrator
Thu 07 Sep 2017 03:32:37 PM UTC, comment #5:

Could you refresh the patch? I tried to apply against tip 24020:387be1a6c3dc and 6/6 hunks were rejected.

I had thought about removing the '&' character too as a workaround so I'm pretty sure this will be a good solution.

Rik <rik5>
Project Administrator
Thu 07 Sep 2017 12:37:31 AM UTC, comment #4:

And here is the promised patch ...

(file #41749)

Torsten <ttl>
Project Member
Thu 07 Sep 2017 12:22:09 AM UTC, comment #3:

I have reopened the bug report and attached a patch that removes any '&' before using the text as variable name. Since a variable name does not intentionally contains an ampersand, this might be a solution to this bug and the one with the multiple tabs for the same variable (bug #51851).

Torsten <ttl>
Project Member
Wed 06 Sep 2017 04:07:57 AM UTC, comment #2:

Yes, another '&' injection by KDE. Marking as Won't Fix as this is an upstream issue.

For anyone else who comes across this report, you need to add the folowing to ~/.config/kdeglobals

Rik <rik5>
Project Administrator
Wed 06 Sep 2017 02:33:04 AM UTC, comment #1:

Another candidate of KDEs "&"-injection? Rik, could you please test this?

I am not sure, how we to handle this, since this KDE "feature" does not only result in some ampersands appearing in titles and texts but really leads to degraded functionality. There is a workaround described in
https://bugs.kde.org/show_bug.cgi?id=337491#c21
but I do not think that this is feasible.

Torsten <ttl>
Project Member
Thu 31 Aug 2017 05:35:51 PM UTC, original submission:

Not all, but many of the pop-up menu entries produce invalid code. As an example, try using one of the plot commands at the end of the right-click menu.

Example:

The generated code contains "&x" when it should just be "x". This is probably something simple where the generated string for eval is pre-pending '&' for some reason. Also, it would be nice if there wasn't a space after the variable name which would keep with Octave's indexing style which is to cuddle the parenthesis with the name when indexing.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41760:  ampersand_v02.patch added by ttl (4KiB - text/x-patch)
file #41749:  ampersand.patch added by ttl (4KiB - text/x-patch)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by ttl (Posted a comment)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 10 Sep 2017 04:04:02 PM UTCttlStatusPatch Reviewed=>Fixed
      Open/ClosedOpen=>Closed
    Fri 08 Sep 2017 03:26:49 PM UTCrik5StatusPatch Submitted=>Patch Reviewed
    Fri 08 Sep 2017 04:52:23 AM UTCttlAttached File-=>Added ampersand_v02.patch, #41760
    Thu 07 Sep 2017 12:37:31 AM UTCttlAttached File-=>Added ampersand.patch, #41749
    Thu 07 Sep 2017 12:22:55 AM UTCttlDependencies-=>bugs #51851 is dependent
    Thu 07 Sep 2017 12:22:09 AM UTCttlStatusWont Fix=>Patch Submitted
      Open/ClosedClosed=>Open
      SummaryVariable Editor pop-up menu entries don't work [KDE only]=>Variable Editor issues resulting from '&' inserted into the tab text by KDE
    Wed 06 Sep 2017 04:07:57 AM UTCrik5StatusNone=>Wont Fix
      Open/ClosedOpen=>Closed
      SummaryVariable Editor pop-up menu entries don't work=>Variable Editor pop-up menu entries don't work [KDE only]

    Back to the top


    Powered by Savane 3.1-cleanup1