bugGNU Octave - Bugs: bug #51904, SUNDIALS configuration test for...

 
 

bug #51904: SUNDIALS configuration test for sizeof(realtype) is not cross-compile-safe

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Thu 31 Aug 2017 04:50:41 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: Mike Miller <mtmiller>
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 02 Sep 2017 07:05:14 PM UTC, comment #4:

@Mike: I see you have fixed it in http://hg.octave.org/mxe-octave/rev/8b731cde3aaa. Thanks.

Avinoam Kalma <avinoam>
Project Member
Fri 01 Sep 2017 07:11:59 PM UTC, comment #3:

Please file a new bug about that. The mxe-octave/src/sundials-ida.mk file will have to be updated to build against the SuiteSparse KLU library for that to work.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Fri 01 Sep 2017 08:36:57 AM UTC, comment #2:

Thanks. Now the cross compilation works, but...

Seems that ida_klu.h is missing, so ode15s will not have a full functionality.

Avinoam Kalma <avinoam>
Project Member
Thu 31 Aug 2017 09:27:05 PM UTC, comment #1:

I fixed this on the default branch

https://hg.savannah.gnu.org/hgweb/octave/rev/eb6602171d59

and tested with my local mxe-octave setup, works for me.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 31 Aug 2017 04:50:41 PM UTC, original submission:

The configure test for whether SUNDIALS is built for double-precision floating point values is not cross-compile-safe. However, since it only relies on compile-time constants, it should be possible to convert it to a AC_COMPILE_IFELSE instead of a AC_RUN_IFELSE, which will make it cross-compile-safe. In other words there is no reason to use a runtime assert in order to test something that can be determined at compile time. I'll take a look at fixing this test.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by avinoam
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 31 Aug 2017 09:27:05 PM UTCmtmillerStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Thu 31 Aug 2017 05:03:36 PM UTCavinoamCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1