bugGNU Octave - Bugs: bug #51872, changed default behavior between...

 
 

bug #51872: changed default behavior between 4.2.1 and dev for marking long lines

Submitted by:  Hartmut <hardy>
Submitted on:  Sun 27 Aug 2017 06:20:12 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: Torsten <ttl>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 02 Sep 2017 08:42:06 PM UTC, comment #7:

Okay, thanks for testing. Closing this bug report.

Torsten <ttl>
Project MemberIn charge of this item.
Sat 02 Sep 2017 08:20:04 PM UTC, comment #6:

I have compiled Octave (hg id a5b20fc6588a) and tested this behavior under (Ubuntu 16.04) linux. I would say it is FIXED now.

Here is what I did:

  • delete my existing "~/.config/octave/qt-settings" file
  • start Octave 4.2.1 GUI to create a new qt-settings file
  • close Octave 4.2.1 GUI
  • start Octave 4.3.0+ GUI
  • open an m-file with long lines in the GUI editor

When I do the last step with an older dev octave, then I see the long lines with a grey background as described in comment #0. But with this new patch, I only get (as default behavior) the vertical line at column 80.

Hartmut <hardy>
Sat 02 Sep 2017 04:05:33 PM UTC, comment #5:

I have pushed changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/a5b20fc6588a
which should fix this issue.

Torsten <ttl>
Project MemberIn charge of this item.
Sun 27 Aug 2017 07:13:55 PM UTC, comment #4:

Hartmut, you are right. The background is accidentally the default marker. When switching from a version without this feature, the background variant is chosen. I will prepare a patch that will fix this.

Torsten <ttl>
Project MemberIn charge of this item.
Sun 27 Aug 2017 06:54:23 PM UTC, comment #3:

Yes, you are right. This seems to be the intended behavior for the setting "Long line marker" = "background". This seems to be a new feature (after 4.2.1 release) that I didn't know before. Sorry.

The only mis-behavior that persists is:

  • I have never touched this "long line marker" setting
  • It was set to "Line" (this is probably the default value)
  • Nevertheless the GUI editor behavior was as described. And this behavior is ment to be for the "background" setting, I assume. I would consider this a mis-behavior.
  • Once I change this setting, (to "none" in my case, and afterwards to "line"), then the GUI editor behaves like expected.
Hartmut <hardy>
Sun 27 Aug 2017 06:39:11 PM UTC, comment #2:

Actually, the reported effect may be a feature. Could you please check the editor preferences for the handling of long lines? Long lines can be marked by a vertical line or by colored background beyond a certain column (useful for non monospaced fonts). The effect you are seeing might be the latter.

Torsten <ttl>
Project MemberIn charge of this item.
Sun 27 Aug 2017 06:36:09 PM UTC, comment #1:

I don't see exactly what you are seeing. But maybe this is how the long line marker appears on your system? I see a fine grey vertical line spanning the whole file at that position
Does it toggle when you check/un-check View->Editor->Show Long Line Marker?

Markus Mützel <mmuetzel>
Project Member
Sun 27 Aug 2017 06:20:12 PM UTC, original submission:

Some (random?) code parts in the GUI editor become "highlighted" with gray background. (I haven't figured out what the logic behind this is.)

Here is how to reproduce it:

  • start the Octave-GUI (--no-init-file)
  • just as a random example: type "edit colorbar" and look at code line 201 or 247.
  • alternatively type "edit plot" and look at code line 204.

I will attach screenshots of this.

I have observed this in the current default branch of Octave (hg id 58435a400d4e), compiled under (Ubuntu 16.04) linux. This does not happen (on the same pc) with a self-compiled Octave 4.2.1 release tar-ball.

Hartmut <hardy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41681:  Screenshot_Plot-L204.png added by hardy (75KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ttl (Posted a comment)
  • -unavailable- added by mmuetzel (Posted a comment)
  • -unavailable- added by hardy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 02 Sep 2017 08:42:06 PM UTCttlStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 02 Sep 2017 04:05:33 PM UTCttlStatusIn Progress=>Ready For Test
    Sun 27 Aug 2017 07:13:55 PM UTCttlStatusNeed Info=>In Progress
      Assigned toNone=>ttl
      Summaryerroneous syntax highlighting in GUI editor=>changed default behavior between 4.2.1 and dev for marking long lines
    Sun 27 Aug 2017 06:39:11 PM UTCttlStatusNone=>Need Info
    Sun 27 Aug 2017 06:20:12 PM UTChardyAttached File-=>Added Screenshot_Colorbar-L201.png, #41680
      Attached File-=>Added Screenshot_Plot-L204.png, #41681

    Back to the top


    Powered by Savane 3.1-cleanup1