bugGNU nano - Bugs: bug #51821, selecting text no longer...

 
 

bug #51821: selecting text no longer highlights it

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Tue 22 Aug 2017 04:05:38 PM UTC  
 
Severity: 5 - BlockerStatus: Fixed
Assigned to: David Lawrence Ramsey <dolorous>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 22 Aug 2017 05:30:16 PM UTC, comment #2:

Thanks for the quick fix! Pushed to master, a850bb25.

And closing, because unreleased.

Benno Schulenberg <bens>
Project Administrator
Tue 22 Aug 2017 04:56:12 PM UTC, comment #1:

The attached patch should fix it. edit_redraw() should always be called on the line we moved from, not the line we're on, so was_current was actually needed. (The patch also adds it back to do_left() and do_right(), so that only one edit_redraw() call is needed for those.)

(file #41617)

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.
Tue 22 Aug 2017 04:05:38 PM UTC, original submission:

To reproduce, run src/nano +1 NEWS, then type M-A and press <Down> several times. Nothing is highlighted. Now press ^L. The highlight appears.

In the revamping of the scrolling in commit 5e105287 we have trimmed away too many lines of code.

Benno Schulenberg <bens>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dolorous (Updated the item)
  • -unavailable- added by bens (Submitted the item)
  • -unavailable- added by bens
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 22 Aug 2017 05:30:16 PM UTCbensStatusNone=>Fixed
      Assigned toNone=>dolorous
      Open/ClosedOpen=>Closed
    Tue 22 Aug 2017 04:56:12 PM UTCdolorousAttached File-=>Added 0001-moving-call-edit_redraw-on-the-proper-line-when-movi.patch, #41617
    Tue 22 Aug 2017 04:05:38 PM UTCbensCarbon-Copy-=>Added dolorous

    Back to the top


    Powered by Savane 3.1-cleanup1