bugGNU nano - Bugs: bug #51777, nano git fails to compile with...

 
 

bug #51777: nano git fails to compile with --enable-tiny --enable-multibuffer --enable-help

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Thu 17 Aug 2017 09:20:38 PM UTC  
 
Severity: 2 - MinorStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Aug 2017 04:18:41 PM UTC, comment #1:

Fixed in git, b38b020d. Thanks for reporting.

And closing, because unreleased.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Thu 17 Aug 2017 09:20:38 PM UTC, original submission:

With current git (e09dbf1), and these configure options, compilation fails at help.c:

help.c: In function ‘do_help’:
help.c:209:21: error: ‘do_findprevious’ undeclared (first use in this function)
} else if (func == do_findprevious) {
^
help.c:209:21: note: each undeclared identifier is reported only once for each function it appears in
help.c:210:6: warning: implicit declaration of function ‘do_findprevious’ [-Wimplicit-function-declaration]
do_findprevious();
^
help.c:212:21: error: ‘do_findnext’ undeclared (first use in this function)
} else if (func == do_findnext || func == do_research) {
^
help.c: In function ‘parse_help_input’:
help.c:582:10: error: ‘do_findprevious’ undeclared (first use in this function)
return do_findprevious;
^
help.c:584:10: error: ‘do_findnext’ undeclared (first use in this function)
return do_findnext;
^
Makefile:1556: recipe for target 'help.o' failed
make[2]: *** [help.o] Error 1

I'm not sure whether these functions should be enabled or disabled here; adding multibuffer support and the help browser makes nano... less than tiny, but findnext/findprevious are usually disabled in tiny mode.

(And yes, I know this is an odd case, but nano does build properly with --enable-tiny --enable-browser, and findnext does work in the file browser then.)

David Lawrence Ramsey <dolorous>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 Aug 2017 04:18:41 PM UTCbensSeverity3 - Normal=>2 - Minor
      StatusNone=>Fixed
      Assigned toNone=>bens
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1