(
Jump to the original submission)
Sat 19 Aug 2017 12:16:55 PM UTC, comment #9:
I have improved SSE2 detection further in
https://sourceforge.net/p/octave/interval/ci/add2b34bf96bf317e2fcee8b05be2d8fc7e6b19f/
To use cat /proc/cpuinfo doesn't work on Windows and doesn't allow cross-compilation.
|
Wed 16 Aug 2017 09:14:48 PM UTC, comment #8:
Works for me, thanks.
|
Wed 16 Aug 2017 09:04:53 PM UTC, comment #7:
No need to send a patch, I have fixed it in the repository already.
https://sourceforge.net/p/octave/interval/ci/db753bae44b3b0ac58af3c7556a1d342cfeeb105/
Actually, I thought that this has already been fixed because the original changeset has been patched into the Debian repository. Then I realized: In Debian the auto-detection is overridden by this:
P.S. Many thanks for packaging @ Fedora.
This bug may be closed.
|
Wed 16 Aug 2017 08:45:56 PM UTC, comment #6:
Thanks! With that, it builds on all Fedora arches. Do you want me to send a patch?
FYI, here's the Fedora request for package review:
https://bugzilla.redhat.com/show_bug.cgi?id=1481604
|
Wed 16 Aug 2017 05:15:55 AM UTC, comment #5:
The correct syntax should be: ifneq ($(HAS_SSE2),)
|
Wed 16 Aug 2017 02:20:37 AM UTC, comment #4:
Agree, this is not fixed by the current changes in the repo, I tested similarly by changing the argument to findstring.
|
Wed 16 Aug 2017 02:02:05 AM UTC, comment #3:
> Seems to me we should just have ...
No no, that's not right because it will just be "sse2" rather then "--enable-sse2". I think I'll let someone who speaks Make fix this properly! The logic should be:
|
Wed 16 Aug 2017 01:51:32 AM UTC, comment #2:
It doesn't work for me.
I cherry-picked that patch. But I always get --enable-sse2, independent of what is in /proc/cpuinfo.
For example, I has findstring for "WTF" instead of "sse2":
And I still get --enable-sse2. Perhaps HAS_SSE2 is defined but empty: [1] says "if it occurs, the value is find; otherwise, the value is empty."
[1] https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
Seems to me we should just have:
But I don't know how to support "?=" with such (which I guess was the reason for the "ifdef HAS_SSE2" stuff.)
|
Tue 15 Aug 2017 07:45:38 AM UTC, comment #1:
It has been fixed already and will be part of the next release after Google summer of code.
https://sourceforge.net/p/octave/interval/ci/f76c17d11bc7fda7f6747464134519a80d779867
|
Tue 15 Aug 2017 07:40:52 AM UTC, original submission:
I'm trying to package octave-interval for Fedora. It works fine on x86 but fails on arm, ppc, etc.
There are various logs here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21237837
(click on one of the red failures), then click on "build.log".
Here's an excerpt:
So it looks like there is some hardcoded sse stuff in there?
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach File(s):
Comment:
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
Follow 7 latest changes.